Enabling Perflint checks

[martinhoyer]

Will probably have negligible performance improvements, but it seems like a low-hanging fruit.
The PERF203 would be a bit more tricky to address fully, but I've at least tried to fix those simpler cases.

Depends on #3402

Pull Request Checklist

• implement the feature

[martinhoyer]

Does this change make sense @happz? I'm thinking

try:
    with suppress(tmt.utils.StructuredFieldError):

except nitrate.NitrateError:
    pass

but not sure if there is an advantage in doing so.

[martinhoyer]

changed in 64f6242

[lukaszachy]

@martinhoyer Huston, a little problem - https://stackoverflow.com/questions/34566806/why-use-contextlib-suppress-as-opposed-to-try-except-with-pass

I've checked same timeit command on python3.13 (my laptop) and it indeed is much worse with suppress.
So I'd say different approach is necessary if the whole point is to get better performance :/

[martinhoyer]

@martinhoyer Huston, a little problem - https://stackoverflow.com/questions/34566806/why-use-contextlib-suppress-as-opposed-to-try-except-with-pass

I've checked same timeit command on python3.13 (my laptop) and it indeed is much worse with suppress. So I'd say different approach is necessary if the whole point is to get better performance :/

Nice, good info. Thanks!

Actually the supress wasn't added as part of performance optimization. The perflint is complaining about try except being inside the loop.
We can do the "same" changes without the supress, by moving the loops within try-except(where applicable).

btw, have you run the timeits with some of the changed code here? Just curious if it's also slower.

[martinhoyer]

Out of curiosity, I've tried to solve the remaining PERF203 and tested modifying this function:

    for i in range(attempts):
        try:
            return func(*args, **kwargs)
        except Exception as exc:
            exceptions.append(exc)
            logger.debug(
                'retry',
                f"{label} failed, {attempts - i} retries left, "
                f"trying again in {interval:.2f} seconds.")
            logger.fail(str(exc))
            time.sleep(interval)
    raise RetryError(label, causes=exceptions)

to

    retries_left = attempts

    while retries_left > 0:
        retries_left -= 1
        try:
            return func(*args, **kwargs)
        except Exception as exc:
            exceptions.append(exc)
            logger.debug(
                'retry',
                f"{label} failed, {retries_left} retries left, "
                f"trying again in {interval:.2f} seconds.")
            logger.fail(str(exc))

            if retries_left > 0:
                time.sleep(interval)

    raise RetryError(label, causes=exceptions)

An the test results over a milion iterations:
Average 1: 0.0000056165 seconds
Average 2: 0.0000056047 seconds

Anyway, I'm going to do something useful.