scripts/bootstrap to rule them all
#3409
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make` is not available by default in Fedora containers.
abitrolly
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
happz
reviewed
Dec 6, 2024
| @@ -65,10 +65,8 @@ rpm: tarball ver2spec ## Build RPMs | |||
| srpm: tarball ver2spec ## Build SRPM | |||
| rpmbuild --define '_topdir $(TMP)' -bs tmt.spec | |||
|
|
|||
| _deps: # Minimal dependencies (common for 'deps' and 'develop' targets) | |||
There was a problem hiding this comment.
This target should be running the newly added script, and both targets bellow would still depend on this target to do the job rather than running it on their own. If there is a "install minimal dependencies" action, it should be a dependable target.
There was a problem hiding this comment.
I am confused about these targets below. Why develop target doesn't include "build dependencies".
What is possible to do with minimal dependencies?
What people are supposed to do in "Develop" mode without build dependencies?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeis not available by default in Fedora containers, so usescripts/bootstrapto get all the stuff ready.Pull Request Checklist