Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply ruff format to tests too #3530

Merged
merged 3 commits into from
Mar 12, 2025
Merged

Apply ruff format to tests too #3530

merged 3 commits into from
Mar 12, 2025
+2,890 −3,047

Conversation

happz
Copy link
Collaborator

@happz happz commented Feb 17, 2025

The last uncovered piece of code base.

Pull Request Checklist

  • implement the feature

@happz happz added test coverage Improvements or additions to test coverage of tmt itself ci | full test Pull request is ready for the full test execution labels Feb 17, 2025
@happz happz added this to the 1.44 milestone Feb 17, 2025
martinhoyer
martinhoyer approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Added obligatory, ignorable trailing comma comments.

@happz happz force-pushed the ruff-format-tests branch from 35774c9 to 0090b8c Compare February 25, 2025 16:50
@psss psss added the priority | could low priority, could be included in the next release label Feb 27, 2025
@happz happz force-pushed the ruff-format-tests branch 2 times, most recently from 6c847ac to a57abb2 Compare March 3, 2025 10:23
@happz happz force-pushed the ruff-format-tests branch 2 times, most recently from 1319271 to 5098821 Compare March 7, 2025 13:25
@happz
Copy link
Collaborator Author

happz commented Mar 10, 2025

/packit build

@happz happz force-pushed the ruff-format-tests branch from 5098821 to a840b2f Compare March 10, 2025 11:39
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Mar 11, 2025
@happz happz force-pushed the ruff-format-tests branch from a840b2f to 0256b86 Compare March 12, 2025 10:10
@martinhoyer martinhoyer merged commit 46cd4f8 into main Mar 12, 2025
5 of 21 checks passed
@martinhoyer martinhoyer deleted the ruff-format-tests branch March 12, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@psss psss psss approved these changes

@martinhoyer martinhoyer martinhoyer approved these changes

@therazix therazix therazix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution priority | could low priority, could be included in the next release status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.44
Development

Successfully merging this pull request may close these issues.
5 participants
@happz @KwisatzHaderach @psss @martinhoyer @therazix