Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --command option for the tmt run reboot command #3532

Merged
merged 3 commits into from
Mar 12, 2025
Merged

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Feb 18, 2025

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@skycastlelily skycastlelily added the ci | full test Pull request is ready for the full test execution label Feb 18, 2025
@skycastlelily skycastlelily modified the milestones: 1.43, 1.44 Feb 18, 2025
@skycastlelily skycastlelily added the status | blocked The merging of PR is blocked on some other issue label Feb 18, 2025
@skycastlelily
Copy link
Collaborator Author

The test failure is due to this hmmm line,
this mr set a default value to command as a result the plugins will call super().reboot(), and hard is True ,so error is raised.
This mr would fix the issue^^

@happz
Copy link
Collaborator

happz commented Feb 18, 2025

The test failure is due to this hmmm line, this mr set a default value to command as a result the plugins will call super().reboot(), and hard is True ,so error is raised. This mr would fix the issue^^

You can change the base branch of this PR to cleanup-guest-reboot-implementations and rebase, that should give you the combination of both patches.

@skycastlelily skycastlelily changed the base branch from main to cleanup-guest-reboot-implementations February 18, 2025 08:54
@skycastlelily
Copy link
Collaborator Author

The test failure is due to this hmmm line, this mr set a default value to command as a result the plugins will call super().reboot(), and hard is True ,so error is raised. This mr would fix the issue^^

You can change the base branch of this PR to cleanup-guest-reboot-implementations and rebase, that should give you the combination of both patches.

Done^^

@happz happz force-pushed the cleanup-guest-reboot-implementations branch from 083fdd4 to b8977d4 Compare February 19, 2025 08:03
@happz happz requested a review from frantisekz as a code owner February 19, 2025 08:03
@happz happz force-pushed the cleanup-guest-reboot-implementations branch from b8977d4 to 20442e7 Compare February 20, 2025 22:09
@lukaszachy lukaszachy force-pushed the cleanup-guest-reboot-implementations branch from 20442e7 to 8b2117f Compare February 24, 2025 13:08
Base automatically changed from cleanup-guest-reboot-implementations to main February 24, 2025 15:37
@happz happz changed the title Add --command option for the tmt run reboot command Add --command option for the tmt run reboot command Feb 25, 2025
@skycastlelily skycastlelily removed the status | blocked The merging of PR is blocked on some other issue label Mar 3, 2025
@skycastlelily skycastlelily force-pushed the reboot-command branch 2 times, most recently from b279b7b to ed4673c Compare March 11, 2025 12:45
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Mar 11, 2025
@martinhoyer martinhoyer merged commit 60d97b8 into main Mar 12, 2025
22 checks passed
@martinhoyer martinhoyer deleted the reboot-command branch March 12, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants