Improve audit events handling in avc check #3562
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinhoyer
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
- Wait for audit backlog to clear before running. ausearch commands. - Use 1s sleep only as a fallback if unable to check backlog status. - Change default method from timestamp to checkpoint.
happz
force-pushed
the
ausearch-checkpoint-mystery
branch
from
487856a to
cded522
Compare
I believe draft isn't the issue, it's the lack of |
happz
reviewed
Mar 2, 2025
| {% endif %} | ||
| """ # noqa: E501 | ||
| ) | ||
| textwrap.dedent(f""" |
There was a problem hiding this comment.
My only comment so far, the mixture of Jinja template and f-strings. I'd pick one of them and stick to it, most likely Jinja. How about passing the "library" variable to render() below, or we could have just one script, doing both things in if/else branches, and just set a variable for it when rendering it as before and after test (ACTION=prepare vs ACTION=check + if [ "$ACTION" = "prepare" ]; ...). Both should let us avoid using two template flavors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When troubleshooting ausearch --checkpoint failing tests in certain environments, I've observed changes in avc check behaviour when many events are being created for processing. For example
sshdfrom tmt ssh connections orsudousage.I haven't found a way a better check to find if all events are 'synced' before running ausearch commands, so I'm parsing
auditctl -soutput, which includes: "backlog field tells how many event records are currently queued waiting for auditd to read them" and make sure it is 0 before proceeding.Unfortunatelly that's not enough to make it work reliably.
Using
--just-onewas a bad idea as ausearch always starts from beginning of the log, with no way to start with the last one. Redirecting stdout to /dev/null seems to be just as fast.I've also tried to get the event id with
tail -1 audit.log, and useauseach -a $id, but that also didn't solve race conditions(I think) that arise from running all this through ssh. Neither does various --format and --escape options...or any other options for that matter.Using
-ts checkpointis ultimately the only way I've found in this sunk-cost-fallacy-rabbit-black-hole. Well, unless we want to have dedicated log file for just avc failures, just for the duration of the test.Needs tests and I'm not quite happy with the bash script and report. Would mark is as draft, but that would not trigger pipelines.
Pull Request Checklist