Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash clone url to ensure clone dir uniqueness #9

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Hash clone url to ensure clone dir uniqueness #9

merged 1 commit into from
Oct 31, 2024

Conversation

janhavlin
Copy link
Collaborator

Solves #8.

@janhavlin janhavlin force-pushed the hash-clone-dir-name branch from f564a4f to d4bacb7 Compare October 24, 2024 08:59
seberm
seberm reviewed Oct 24, 2024
View reviewed changes
src/tmt_web/utils/git_handler.py Outdated Show resolved Hide resolved
src/tmt_web/utils/git_handler.py Outdated Show resolved Hide resolved
@psss psss linked an issue Oct 24, 2024 that may be closed by this pull request
Incorrect repository caching #8
Closed
@psss psss mentioned this pull request Oct 24, 2024
Merged
@janhavlin janhavlin force-pushed the hash-clone-dir-name branch from d4bacb7 to 62e3d64 Compare October 25, 2024 11:46
@martinhoyer
Copy link
Contributor

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

CodiumAI-Agent commented Oct 25, 2024 •
edited
Loading

PR Reviewer Guide 🔍

(Review updated until commit aeb7b83)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

8 - Partially compliant

Fully compliant requirements:

  • Ensure that different repositories with similar names under different users are uniquely identified and cloned separately.

Not compliant requirements:

  • Fix the bug where querying a fork of a repository results in displaying data from the wrong repository due to incorrect caching.
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Bug
The implementation uses SHA-256 hashing of the URL to create unique directory names for repository cloning. However, it does not address potential issues with the caching mechanism itself, which might still serve data from an incorrect cache.

@martinhoyer
Copy link
Contributor

I thought this would be a decent place to try the AI review thing. Let's see...

@CodiumAI-Agent
Copy link

Persistent review updated to latest commit 62e3d64

@janhavlin janhavlin force-pushed the hash-clone-dir-name branch 2 times, most recently from c4ea652 to c8ab810 Compare October 29, 2024 16:18
@janhavlin janhavlin changed the base branch from use_fast_api to main October 29, 2024 16:18
@janhavlin
Copy link
Collaborator Author

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

Persistent review updated to latest commit c8ab810

@psss psss force-pushed the hash-clone-dir-name branch from c8ab810 to aeb7b83 Compare October 30, 2024 08:53
@psss psss self-assigned this Oct 30, 2024
psss
psss approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@psss psss requested review from seberm and happz October 30, 2024 08:57
seberm
seberm approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@seberm seberm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@psss psss merged commit aaa8fc4 into teemtee:main Oct 31, 2024
2 checks passed
@CodiumAI-Agent
Copy link

Persistent review updated to latest commit aeb7b83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@seberm seberm seberm approved these changes

@happz happz Awaiting requested review from happz

Assignees

@psss psss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect repository caching
6 participants
@janhavlin @martinhoyer @CodiumAI-Agent @happz @seberm @psss