Feature/show dao token balance #332
Conversation
|
| .catch(error => console.log('Error while querying the account token balance:', error)) | ||
|
|
||
| return response?.data[0]? parseInt(response.data[0]) / 1e6 : 0 | ||
| } | ||
|
|
There was a problem hiding this comment.
We probably can also use teztok here? I guess it doesn't matter that much
There was a problem hiding this comment.
Nope it's actually not indexed and IIRC @xat mentionned it not being very adequate to store there so this is totally fine
There was a problem hiding this comment.
Looks perfectly fine to me! I would just handle error on awaiting for the Dao token so that it doesn't bork everything if tzkt is down and either display an error dialog or just default to -1, 0, X or ERROR for the count value displayed (or even hide it if missing simply)
src/data/api.ts
Outdated
| 'account': walletAddr, | ||
| "select": 'balance'} | ||
| const response = await axios.get(`https://api.tzkt.io/v1/tokens/balances`, { params: parameters }) | ||
| .catch(error => console.log('Error while querying the account token balance:', error)) |
There was a problem hiding this comment.
Is this not doing what you want @melMass ?
There was a problem hiding this comment.
It will return 0 tokens, unless i did something wrong.
There was a problem hiding this comment.
Can the tzkt url be changed to VITE_TZKT_API ? If we ever need to switch tzkt instances, then we only need to change it in https://github.com/teia-community/teia-ui/blob/main/.env
There was a problem hiding this comment.
Yes indeed, I did not get that the last ? here is a conditional and not a null property fallback
Line 337 in 364e3c2
Are you sure the hooks are running 🤣 ?
There was a problem hiding this comment.
Can the tzkt url be changed to
VITE_TZKT_API? If we ever need to switch tzkt instances, then we only need to change it in https://github.com/teia-community/teia-ui/blob/main/.env
Did it in my last commit
There was a problem hiding this comment.
Mergeable for me, I would just double check hooks are ran I find it stange that it did not add a space here before the last ?:
Line 337 in 364e3c2
src/data/api.ts
Outdated
| 'account': walletAddr, | ||
| "select": 'balance'} | ||
| const response = await axios.get(`https://api.tzkt.io/v1/tokens/balances`, { params: parameters }) | ||
| .catch(error => console.log('Error while querying the account token balance:', error)) |
There was a problem hiding this comment.
Yes indeed, I did not get that the last ? here is a conditional and not a null property fallback
Line 337 in 364e3c2
Are you sure the hooks are running 🤣 ?
|
Yes. I was wondering about the hooks... I didn't have any error when committing, so i assumed they run fine... Maybe is because i commit directly without staging when i use eclipse? |
|
Not sure if i'm allowed to merge... I did another change and it seems that the hooks are disabled in my commits? I have no clue how to fix that... |
What is your OS? The hooks are installed on first |
I use linux... I installed the repo with npm install and npm start |
You can always run prettier manually but we should find why it's doing that, I personally commit from the command line, but GUI tools shouldn't bypass it unless specifically asked to, maybe you disabled it when you initially had the issue and the config was kept or something like that |
|
How do you run it locally? npm lint ? |
|
I cloned again the repo to be sure before my last commit and it still didn't run the hooks. |
|
|
Ok. That did work. I will use it. Even from a clean install i got 2 files that needed format changes:
|
Hi! This PR adds the TEIA balance info in the user profile. I hope i followed the standard way to do it!