Integrate DAO UI #333
Integrate DAO UI #333
Conversation
|
|
Hi. All needed things should be there. The CSS is terrible and should be improved. It should also use the teia form components in the proposal creation page, but i'm to confused to use them... Could anyone of you take care of that? I think from this moment you can start to help me to do things better and nicer. I don't plan to touch this today anymore. |
|
Ok, i lied... |
I have a similar issue, I told everyone I was free at the same time 😅 ! |
Great! teia.art/polls/123 |
|
55 files changed or added. If you let me continue working in this PR i'm sure i can reach 100! XD |
|
I'm merging back main now. |
Sure. Go for it! |
There was a problem hiding this comment.
All good for me, the only small improvements I can see but that aren't that critical:
- I think we can merge SimpleInput and Input.
- Some places use "raw" html buttons
- We could extract the tables into a Table component
- Claim should probably be removed now (we are the 21)
- @jagracar has to update the contract urls once redeployed.
But overall it's well organised and can be merged once ready
| import styles from '@style' | ||
|
|
||
| export default function SimpleInput({ | ||
| type, | ||
| label, | ||
| min, | ||
| max, | ||
| step, | ||
| minlength, | ||
| maxlength, | ||
| placeholder, | ||
| value, | ||
| onChange, | ||
| pattern, | ||
| className, | ||
| children, | ||
| }) { | ||
| const handleInput = (e) => | ||
| onChange(type === 'file' ? e.target.files?.[0] : e.target.value) | ||
|
|
||
| return ( | ||
| <div className={`${styles.container} ${className ?? ''}`}> | ||
| <label> | ||
| <p>{label}</p> | ||
| <input | ||
| type={type} | ||
| min={min} | ||
| max={max} | ||
| step={step} | ||
| minLength={minlength} | ||
| maxLength={maxlength} | ||
| placeholder={placeholder} | ||
| value={value} | ||
| onChange={handleInput} | ||
| pattern={pattern} | ||
| autoComplete="off" | ||
| /> | ||
| </label> | ||
| {children} | ||
| </div> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Do you remember why this was needed? I just tried replacing them all with the Input one and it seems to work fine but I remember you mentioned having issues with it.
There was a problem hiding this comment.
I had weird problems when i was using a map to create a list of inputs. For example, for the list of addresses in a tez transfer proposal
There was a problem hiding this comment.
I see let's not break it now it could be refactored later!
Very very good job overall 👏
|
Thank you for the review, @melMass ! I think we could remove or update the claim page in another PR. We probably should also remove the banner that announced the claim process. |
Unless it becomes too complex I would do it here
Yep that's dealt with there, merch just did 😋 teia-community/teia-status@5f053ab |
|
Working on it now. Should I remove everything? Or just the direct links to the claim page? It could be useful to keep the old code for future claim processes |
Yep I would keep it all just remove it's direct access from the menu |
|
I redeployed the contracts and updated the UI. I think we can probably merge this tomorrow. |
|
We will probably merge it tomorrow. I just need to click the "Squash and merge" button, right? |
It's maybe better to rebase merge this one, it will be a massive commit otherwise |
In this PR i will try to include the DAO UI into the teia page
Still a lot of things to be done
Feel free to modify at will