Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some people have username.js as subjkt, this overrides the content-type #338

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

Zir0h
Copy link
Contributor

@Zir0h Zir0h commented Oct 19, 2023

@jagracar found this profile which is currently broken because of the .js suffix 😅 https://teia.art/marcmaurer.js
2023-10-19-165210_676x416_scrot

@Zir0h Zir0h changed the title some people have username.js as subjkt, this overrides the content-type fix: some people have username.js as subjkt, this overrides the content-type Oct 19, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-19 16:11 UTC

@Zir0h
Copy link
Contributor Author

Zir0h commented Oct 19, 2023

not testable on the GitHub pr pages I'm afraid, it's only when the visitor directly accesses the profile

@melMass
Copy link
Member

melMass commented Oct 19, 2023

not testable on the GitHub pr pages I'm afraid, it's only when the visitor directly accesses the profile

Just after the review of Jag's PR I want to solve this issue, it should be doable with a vite config change based on the base url

Copy link
Member

@melMass melMass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@melMass melMass merged commit 7b1b337 into main Oct 19, 2023
2 checks passed
@melMass melMass deleted the fix-js-usernames branch October 19, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants