This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
Single quotes #46
Open
Single quotes #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinefjord
suggested changes
May 6, 2018
| @@ -0,0 +1,39 @@ | |||
| <style> | |||
There was a problem hiding this comment.
I feel like <style></style> should be in the template, the .css file should only contain CSS.
| display: none; | ||
| } | ||
| </style> | ||
| {% include 'strecklista/components/quote.css' %} |
There was a problem hiding this comment.
<style>
{% include 'strecklista/components/quote.css' %}
</style>
| @@ -4,4 +4,7 @@ | |||
| <div class="quotee">{{ quote.who }}</div> | |||
| <div class="detail">{{ quote.timestamp }}</div> | |||
| </div> | |||
| <div class="quote-link"> | |||
| Permanent länk: <a href="{{ request.get_host }}/quote/{{ quote.id }}">{{ request.get_host }}/quote/{{ quote.id }}</a> | |||
There was a problem hiding this comment.
Anchor must have the protocol in href, otherwise request.get_host is interpreted as the protocol. Should be href="//{{ request.get_host C}}[...]", note the //. Isn't {% url 'view.name' quote=quote.id %} the correct way to do this though?
Also, <a href="...">Permanent länk</a> is IMHO better UX. It's how hyperlinks are intended to be used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.