Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding v1 ApiVersioning compatibility for catlins pre-commit hooks #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arifash01
Copy link

@arifash01 arifash01 commented Mar 15, 2024

Running catlin pre-commit hooks on yaml files with apiVersion v1 and kind task failed. This is a minimal fix that adds some support for v1 and maintains support to v1beta1.
Issue: #10

Copy link

linux-foundation-easycla bot commented Mar 15, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: arifash01 / name: Arif Ashogbon (3b43dfd)

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign piyush-garg after the PR has been reviewed.
You can assign the PR to them by writing /assign @piyush-garg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested review from chmouel and sm43 March 15, 2024 15:17
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 15, 2024
@tekton-robot
Copy link

Hi @arifash01. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 15, 2024
Copy link

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 15, 2024
@khrm
Copy link

khrm commented Mar 15, 2024

@arifash01 Please sign the cla.

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-catlin-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/linter/script.go 68.0% 69.0% 1.0
pkg/validator/task_validator.go 93.0% 77.6% -15.4

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2024
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-catlin-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/linter/script.go 68.0% 69.0% 1.0
pkg/validator/task_validator.go 93.0% 77.6% -15.4

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-catlin-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/linter/script.go 68.0% 69.0% 1.0
pkg/validator/task_validator.go 93.0% 77.6% -15.4

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-catlin-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/linter/script.go 68.0% 69.0% 1.0
pkg/validator/task_validator.go 93.0% 77.6% -15.4

@arifash01
Copy link
Author

@arifash01 Please sign the cla.

done

Copy link

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @PuneetPunamiya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants