-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove create clusterrole in triggers test #2471
Conversation
This will remove creating clusterrole in triggers test as it is shipped by triggers now and an be used in clusterolebinding
thanks 🙏🏻 i think we can force approve to unlock ci /lgtm |
773146f
to
4c1e9b2
Compare
149f7c3
to
91268d3
Compare
The CI should be green though 🤔 |
The issue is different but still legit I think. |
ad5c381
to
0a8c384
Compare
This will fix eventlistener permissions and will send a dummy event to trigger logs
/retest |
@vdemeester @chmouel @divyansh42 @pratap0007 Fixed the tests |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will remove creating clusterrole in triggers test as it is shipped by triggers now and an be used in clusterolebinding
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes