Check for the wrong start date

[jisoolee]

Add wrongDateChecker to catch the wrong start date which is causing the wrong duration for PipelineRuns and TaskRuns

Changes

This will prevent to show the wrong duration for the users.
Related issue: https://github.ibm.com/one-pipeline/adoption-issues/issues/1374

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

Hi @jisoolee. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AlanGreene]

/kind bug

[AlanGreene]

Thanks for the PR @jisoolee. I've left a suggestion for a change to make sure handles some other possible bad input.

[AlanGreene]

If the startTime is either an empty string '' or undefined this will not give the expected result.

new Date('') and new Date(undefined) both result in an 'Invalid Date' object, and the call to getTime() will return NaN instead of 0.

Since this is a relatively simple expression we can just inline it in the if-statement after we've already checked that startTime is truthy so we know it won't hit these cases.

Suggested change

	const wrongDateChecker = new Date(startTime).getTime()
	if (!startTime || !endTime || wrongDateChecker == 0) {
	if (!startTime || !endTime || new Date(startTime).getTime() == 0) {

[jisoolee]

Thank you @AlanGreene for the suggestion and catching that. I did not think about those cases.

I applied the change.

[AlanGreene]

/ok-to-test

[AlanGreene]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AlanGreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment