Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Results configuration in tekton config #2398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Results configuration in tekton config #2398

wants to merge 1 commit into from
+602 −12

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Nov 7, 2024 •
edited
Loading

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

This will add the Results configuration to the tekton config and will be installed by default through tekton config

@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 7, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign concaf after the PR has been reviewed.
You can assign the PR to them by writing /assign @concaf in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2024
khrm
khrm reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create documentation for this PR?

@jkandasa
Copy link
Member

@pratap0007 include the doc changes[1] on this PR
[1] - #2400

@pratap0007 pratap0007 force-pushed the default-results branch 2 times, most recently from dbb72d6 to 42f99c8 Compare November 25, 2024 07:47
@pratap0007 pratap0007 changed the title [WIP] Automate the results installation process Add Results configuration in tekton config Nov 25, 2024
@pratap0007 pratap0007 marked this pull request as ready for review November 25, 2024 07:58
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 45.7% 46.2% 0.6
pkg/reconciler/openshift/tektonresult/extension.go 52.0% 46.8% -5.2
pkg/reconciler/shared/tektonconfig/controller.go Do not exist 0.0%
pkg/reconciler/shared/tektonconfig/result/result.go Do not exist 71.4%
pkg/reconciler/shared/tektonconfig/tektonconfig.go Do not exist 0.0%

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 45.7% 46.2% 0.6
pkg/reconciler/openshift/tektonresult/extension.go 52.0% 46.8% -5.2
pkg/reconciler/shared/tektonconfig/controller.go Do not exist 0.0%
pkg/reconciler/shared/tektonconfig/result/result.go Do not exist 71.4%
pkg/reconciler/shared/tektonconfig/tektonconfig.go Do not exist 0.0%

@pratap0007 pratap0007 force-pushed the default-results branch 2 times, most recently from 1c5b5ff to 13655eb Compare November 25, 2024 09:46
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 25, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 45.7% 46.2% 0.6
pkg/reconciler/openshift/tektonresult/extension.go 52.0% 46.8% -5.2
pkg/reconciler/shared/tektonconfig/controller.go Do not exist 0.0%
pkg/reconciler/shared/tektonconfig/result/result.go Do not exist 71.4%
pkg/reconciler/shared/tektonconfig/tektonconfig.go Do not exist 0.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 45.7% 46.2% 0.6
pkg/reconciler/openshift/tektonresult/extension.go 52.0% 46.8% -5.2
pkg/reconciler/shared/tektonconfig/controller.go Do not exist 0.0%
pkg/reconciler/shared/tektonconfig/result/result.go Do not exist 71.4%
pkg/reconciler/shared/tektonconfig/tektonconfig.go Do not exist 0.0%

@pratap0007
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests
/test pull-tekton-operator-build-tests

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 45.7% 46.2% 0.6
pkg/reconciler/openshift/tektonresult/extension.go 52.0% 46.8% -5.2
pkg/reconciler/shared/tektonconfig/controller.go Do not exist 0.0%
pkg/reconciler/shared/tektonconfig/result/result.go Do not exist 71.4%
pkg/reconciler/shared/tektonconfig/tektonconfig.go Do not exist 0.0%

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 26, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 45.7% 46.2% 0.6
pkg/reconciler/openshift/tektonresult/extension.go 52.0% 46.8% -5.2
pkg/reconciler/shared/tektonconfig/controller.go Do not exist 0.0%
pkg/reconciler/shared/tektonconfig/result/result.go Do not exist 71.4%
pkg/reconciler/shared/tektonconfig/tektonconfig.go Do not exist 0.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 45.7% 46.2% 0.6
pkg/reconciler/openshift/tektonresult/extension.go 52.0% 46.8% -5.2
pkg/reconciler/shared/tektonconfig/controller.go Do not exist 0.0%
pkg/reconciler/shared/tektonconfig/result/result.go Do not exist 71.4%
pkg/reconciler/shared/tektonconfig/tektonconfig.go Do not exist 0.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 45.7% 46.2% 0.6
pkg/reconciler/openshift/tektonresult/extension.go 52.0% 46.8% -5.2
pkg/reconciler/shared/tektonconfig/controller.go Do not exist 0.0%
pkg/reconciler/shared/tektonconfig/result/result.go Do not exist 71.4%
pkg/reconciler/shared/tektonconfig/tektonconfig.go Do not exist 0.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 45.7% 46.2% 0.6
pkg/reconciler/openshift/tektonresult/extension.go 52.0% 46.8% -5.2
pkg/reconciler/shared/tektonconfig/controller.go Do not exist 0.0%
pkg/reconciler/shared/tektonconfig/result/result.go Do not exist 71.4%
pkg/reconciler/shared/tektonconfig/tektonconfig.go Do not exist 0.0%

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 45.7% 46.2% 0.6
pkg/reconciler/openshift/tektonresult/extension.go 52.0% 46.8% -5.2
pkg/reconciler/shared/tektonconfig/controller.go Do not exist 0.0%
pkg/reconciler/shared/tektonconfig/result/result.go Do not exist 71.4%
pkg/reconciler/shared/tektonconfig/tektonconfig.go Do not exist 0.0%

@pratap0007
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests

2 similar comments
@pratap0007
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests

@pratap0007
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests

@pratap0007
Add Results configuration in tekton config
00bbc52 
This will add the Results configuration to the tekton config and will be
installed by default through tekton config

Signed-off-by: Shiv Verma <[email protected]>
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go 45.7% 46.2% 0.6
pkg/reconciler/openshift/tektonresult/extension.go 52.0% 50.0% -2.0
pkg/reconciler/shared/tektonconfig/controller.go Do not exist 0.0%
pkg/reconciler/shared/tektonconfig/result/result.go Do not exist 71.4%
pkg/reconciler/shared/tektonconfig/tektonconfig.go Do not exist 0.0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm left review comments

@jkhelil jkhelil Awaiting requested review from jkhelil

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratap0007 @tekton-robot @jkandasa @khrm