-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per-feature Flag Test Suite #7627
Conversation
Thanks for this @JeromeJu ! Looks good to me. Is there a plan to run this as part of our CI? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks Chitrang for the review. Per discussion at tektoncd/plumbing#1629 (comment), let's have this in nightly first while we had some concern mentioned earlier. We could move it to be part of the per-build CI once we are actually having more per-feature flags(as the possibility of inter-correlation increases) and the nightly are proven to be effective. |
7588c2a
to
4e458a8
Compare
cc @tektoncd/core-maintainers can I have a lgtm for this change please? |
This commit releases the per feature flag test. It currently utilize minimum end-to-end tests for stable features while mocking stable, beta and alpha stability with different test envs. /kind misc
4e458a8
to
3728063
Compare
/test pull-tekton-pipeline-beta-integration-tests |
/lgtm |
Changes
Now that we have more per-feature flags in place, this PR adds the
per feature flag test. It currently utilize minimum end-to-end tests for
stable features while mocking stable, beta and alpha stability with
different test envs.
Currently this runs ~ 970s for my local env with 4 per-feature flags,
which is a reasonable amount since we are likely to be able to have a max
of ~ 12 flags within the timeframe of 60mins.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes