Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for when within matrix.include #8210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chengjoey
Copy link
Member

@chengjoey chengjoey commented Aug 19, 2024

Changes

add support for when within matrix.include
feat #8152

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

matrix.include support when expressions

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2024
@chengjoey
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 19, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/matrix_types.go 100.0% 98.6% -1.4
pkg/apis/pipeline/v1/pipeline_validation.go 99.3% 99.0% -0.2
pkg/apis/pipeline/v1beta1/matrix_types.go 100.0% 98.6% -1.4
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 95.4% 91.2% -4.1
pkg/reconciler/pipelinerun/resources/apply.go 97.3% 96.8% -0.6
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.7% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/matrix_types.go 100.0% 98.6% -1.4
pkg/apis/pipeline/v1/pipeline_validation.go 99.3% 99.0% -0.2
pkg/apis/pipeline/v1beta1/matrix_types.go 100.0% 98.6% -1.4
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 95.4% 91.2% -4.1
pkg/reconciler/pipelinerun/resources/apply.go 97.3% 96.8% -0.6
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.7% 0.0

@chengjoey
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/matrix_types.go 100.0% 98.6% -1.4
pkg/apis/pipeline/v1/pipeline_validation.go 99.3% 99.0% -0.2
pkg/apis/pipeline/v1beta1/matrix_types.go 100.0% 98.6% -1.4
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 95.4% 91.2% -4.1
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.8% -0.2
pkg/reconciler/pipelinerun/resources/apply.go 97.3% 96.8% -0.6
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.7% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/matrix_types.go 100.0% 98.6% -1.4
pkg/apis/pipeline/v1/pipeline_validation.go 99.3% 99.0% -0.2
pkg/apis/pipeline/v1beta1/matrix_types.go 100.0% 98.6% -1.4
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 95.4% 91.2% -4.1
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.0% 98.8% -0.2
pkg/reconciler/pipelinerun/resources/apply.go 97.3% 96.8% -0.6
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.7% 0.0

@tekton-robot
Copy link
Collaborator

@chengjoey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-build-tests 627c308 link true /test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants