Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for priorityClassName in affinityAssistantPodTemplate #8286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for priorityClassName in affinityAssistantPodTemplate #8286

wants to merge 1 commit into from

Conversation

piyush-garg
Copy link
Contributor

This will add the support for specifying priorityClassName for affinity assistant pods. Also can specify default value in defaultAffinityAssistant pod template

this will help to specify same priorityClassName for affinity assistant pods and task run pods, so all get scheduled with same priority

Part of #7779

/kind feature

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 23, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jeromeju after the PR has been reviewed.
You can assign the PR to them by writing /assign @jeromeju in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2024
@vdemeester vdemeester marked this pull request as ready for review September 23, 2024 13:24
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@piyush-garg piyush-garg marked this pull request as draft September 23, 2024 13:26
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/pod/template.go 73.3% 71.4% -1.9
pkg/reconciler/pipelinerun/affinity_assistant.go 97.0% 97.1% 0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/pod/template.go 73.3% 71.4% -1.9
pkg/reconciler/pipelinerun/affinity_assistant.go 97.0% 97.1% 0.1

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/pod/template.go 73.3% 71.4% -1.9
pkg/reconciler/pipelinerun/affinity_assistant.go 97.0% 97.1% 0.1

@piyush-garg piyush-garg marked this pull request as ready for review September 26, 2024 17:32
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/pod/template.go 73.3% 71.4% -1.9
pkg/reconciler/pipelinerun/affinity_assistant.go 97.0% 97.1% 0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/pod/template.go 73.3% 71.4% -1.9
pkg/reconciler/pipelinerun/affinity_assistant.go 97.0% 97.1% 0.1

@piyush-garg
Copy link
Contributor Author

/test pull-tekton-pipeline-integration-tests

@piyush-garg
Add support for priorityClassName in affinityAssistantPodTemplate
a0027a3 
This will add the support for specifying priorityClassName
for affinity assistant pods. Also can specify default
value in defaultAffinityAssistant pod template

this will help to specify same priorityClassName for
affinity assistant pods and task run pods, so all get
scheduled with same priority

Part of tektoncd#7779

/kind feature
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/pod/template.go 73.3% 88.3% 15.0
pkg/reconciler/pipelinerun/affinity_assistant.go 97.0% 97.1% 0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/pod/template.go 73.3% 88.3% 15.0
pkg/reconciler/pipelinerun/affinity_assistant.go 97.0% 97.1% 0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer Awaiting requested review from abayer

@pritidesai pritidesai Awaiting requested review from pritidesai

@jerop jerop Awaiting requested review from jerop

@vdemeester vdemeester Awaiting requested review from vdemeester

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piyush-garg @tekton-robot