Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark steps as deleted when TaskRun fails #8294

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Mark steps as deleted when TaskRun fails #8294

merged 1 commit into from
Sep 25, 2024

Conversation

afrittoli
Copy link
Member

Changes

Today this is done after the Pod is handled. If Pod deletion fails for some reason, the steps are not updated.

Tekton only makes one attempt to delete the Pod to try and avoid that it keeps running even if the TaskRun failed. If this deletion fails for whatever reason, Tekton should still update the TaskRun status to mark the steps as failed, as they are failed from Tekton POV.

Fixes: #8293

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind flake

@afrittoli
Mark steps as deleted when TaskRun fails
264be71 
Today this is done after the Pod is handled. If Pod deletion fails
for some reason, the steps are not updated.

Tekton only makes one attempt to delete the Pod to try and avoid
that it keeps running even if the TaskRun failed. If this deletion
fails for whatever reason, Tekton should still update the TaskRun
status to mark the steps as failed, as they are failed from
Tekton POV.

Fixes: tektoncd#8293

Signed-off-by: Andrea Frittoli <[email protected]>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/flake Categorizes issue or PR as related to a flakey test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2024
@tekton-robot tekton-robot added this to the Pipeline v0.64 milestone Sep 25, 2024
@chitrangpatel
Copy link
Member

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
vdemeester
vdemeester approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We may want to cherry-pick those to the currently supported LTS as well, isn't it ?

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chitrangpatel,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit f59eea0 into tektoncd:main Sep 25, 2024
14 checks passed
@afrittoli
Copy link
Member Author

/cherry-pick release-v0.62.x

@afrittoli
Copy link
Member Author

/cherry-pick release-v0.59.x

@afrittoli
Copy link
Member Author

/cherry-pick release-v0.56.x

@afrittoli
Copy link
Member Author

/cherry-pick release-v0.53.x

@tekton-robot
Copy link
Collaborator

@afrittoli: new pull request created: #8295

In response to this:

/cherry-pick release-v0.62.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 25, 2024
Merged
Merged
@tekton-robot
Copy link
Collaborator

@afrittoli: new pull request created: #8296

In response to this:

/cherry-pick release-v0.59.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@afrittoli: new pull request created: #8297

In response to this:

/cherry-pick release-v0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Sep 25, 2024
Merged
@tekton-robot
Copy link
Collaborator

@afrittoli: #8294 failed to apply on top of branch "release-v0.53.x":

Applying: Mark steps as deleted when TaskRun fails
Using index info to reconstruct a base tree...
M	pkg/reconciler/taskrun/taskrun.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/taskrun/taskrun.go
CONFLICT (content): Merge conflict in pkg/reconciler/taskrun/taskrun.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Mark steps as deleted when TaskRun fails
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member Author

/cherry-pick release-v0.63.x

@tekton-robot
Copy link
Collaborator

@afrittoli: new pull request created: #8298

In response to this:

/cherry-pick release-v0.63.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Sep 25, 2024
Open
@afrittoli afrittoli mentioned this pull request Sep 25, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flakey test lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Pipeline v0.64
Development

Successfully merging this pull request may close these issues.

TestStepTimeout is flaky
4 participants
@afrittoli @chitrangpatel @tekton-robot @vdemeester