Add Failed Validation group in message for the status message in PipelineRun

[divyansh42]

Changes

Following up on the #8314, this PR adds more specific error on the ValidationFailure and also remove the ValidationFailure task from the completed task as there will be no TaskRun created for the same. Validation Failed is added to the another group in the message.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[divyansh42]

/kind bug

[divyansh42]

/cc @afrittoli @vdemeester
Could you please take a look at the changes? This is a minor change and a follow up on #8314

[divyansh42]

/cc @vdemeester

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	99.2%	98.5%	-0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	99.2%	98.5%	-0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	99.2%	98.5%	-0.7

[vdemeester]

cc @afrittoli

[afrittoli]

NIT: I find this slightly confusing. The PipelineRun, made of two tasks, is finished, with 1 Task completed (failed) and nothing else. The reason "PipelineValidationFailed" helps a bit to explain what happens, but not fully.
Perhaps we could consider the second TaskRun as failed or add a new group "Validation Failed" e.g.

• Tasks Completed: 1 (Failed: 1, Cancelled 0), Skipped: 0, Failed Validation: 1

If we wanted to avoid adding another group, we could count the failed validation as failed:

• Tasks Completed: 2 (Failed: 2, Cancelled 0), Skipped: 0

@divyansh42 @vdemeester wdyt?

[vdemeester]

Ah makes sense ! I do like the idea of having the Failed Validation group.

[divyansh42]

Thanks for bringing this up @afrittoli. I also had this thought earlier.
So from the example that @afrittoli is referencing the complete count is 1 and the Failed task is the one that failed in the validation.
I included validationFailed in the failed task as I see in the code IgnoredFailed is also included in the Failed count so followed the same approach.
I do like the idea of adding the FailedValidation count.

[divyansh42]

@afrittoli I have made the required changes. Could you please take a look?

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	99.2%	98.1%	-1.1

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	99.2%	98.1%	-1.1

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	99.2%	98.1%	-1.1

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	99.2%	98.1%	-1.1

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afrittoli]

Thank you!
/lgtm

[vdemeester]

/cherry-pick release-v0.65.x

[vdemeester]

/cherry-pick release-v0.62.x

[tekton-robot]

@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.65.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.65.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.62.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.62.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vdemeester]

/cherry-pick release-v0.59.x

[tekton-robot]

@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.59.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.59.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vdemeester]

/cherry-pick release-v0.56.x

[tekton-robot]

@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.56.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

@vdemeester: new pull request created: #8371

In response to this:

/cherry-pick release-v0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

@vdemeester: new pull request created: #8372

In response to this:

/cherry-pick release-v0.65.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

@vdemeester: new pull request created: #8373

In response to this:

/cherry-pick release-v0.62.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

@vdemeester: new pull request created: #8374

In response to this:

/cherry-pick release-v0.59.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.