Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/attribute type key (workaround) #1920

Merged
merged 4 commits into from
Sep 2, 2020
Merged

Conversation

IvanHdzC
Copy link
Contributor

@IvanHdzC IvanHdzC commented Sep 2, 2020

This PR is related to #1904

This is not the final solution, it's just a workaround, the final solution is still pending.

@AlvaroVega AlvaroVega changed the title Fix/attribute type key Fix/attribute type key (workaround) Sep 2, 2020
Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit c886ae8 into master Sep 2, 2020
@AlvaroVega AlvaroVega deleted the fix/attribute_type_key branch September 2, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants