Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Ctrl+F by F for full screen #26895

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

GooseOb
Copy link

@GooseOb GooseOb commented Oct 5, 2023

F as a hotkey is commonly used for toggling full screen and is used in Telegram Web too. Also, there are hotkeys in Telegram Web such as Shift+F, Alt+F, and Ctrl+F that make video go fullscreen.

Previously Ctrl+F hotkey used to make the search bar active, but as far as I can see it got fixed by now.

Closes #25866

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

@23rd
Copy link
Collaborator

23rd commented Oct 5, 2023

Why don't you like Ctrl+Enter and Alt+Enter?

@GooseOb
Copy link
Author

GooseOb commented Oct 6, 2023

I'm used to use F on youtube and found out about the shortcuts you mentioned while I was searching for shortcuts in the code

@23rd
Copy link
Collaborator

23rd commented Oct 12, 2023

I think changing hotkey that previously worked for years is a bad practice. I think I'll add an ability to customize hotkey to toggle full screen for videos.

@Aokromes
Copy link
Collaborator

I think changing hotkey that previously worked for years is a bad practice. I think I'll add an ability to customize hotkey to toggle full screen for videos.

for all plz xd everyone wants to customize hotkeys :)

@GooseOb
Copy link
Author

GooseOb commented Oct 12, 2023

But Ctrl+F still works, why is adding new hotkeys bad?

@23rd
Copy link
Collaborator

23rd commented Oct 12, 2023

But Ctrl+F still works

Hmm, yes, you're right. Alright then, anyway the final decision is up to Preston.

@23rd
Copy link
Collaborator

23rd commented Oct 30, 2023

Now you can customize this shortcut with a new media_viewer_video_fullscreen key in the shortcuts-custom.json file.

@GooseOb
Copy link
Author

GooseOb commented Nov 2, 2023

I've changed config and now I cannot type f

@23rd
Copy link
Collaborator

23rd commented Nov 2, 2023

I've changed config and now I cannot type f

😯

@23rd
Copy link
Collaborator

23rd commented Nov 5, 2023

But Ctrl+F still works, why is adding new hotkeys bad?

Okay, there seems to be nothing critical to have an additional hotkey option...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report / Feature Request] change shortcut to open video in fullscreen
4 participants