Merge pull request #63 from telekom-mms/feature/handle-dname-records-…

…in-dnsproxy Handle DNAME records in DNS Proxy
telekom-mms · Mar 25, 2024 · b2c2524 · b2c2524
2 parents 9b9b57a + a30bc5d
commit b2c2524
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/internal/dnsproxy/proxy.go b/internal/dnsproxy/proxy.go
@@ -93,6 +93,19 @@ func (p *Proxy) handleRequest(w dns.ResponseWriter, r *dns.Msg) {
 				"ttl":    ttl,
 			}).Debug("DNS-Proxy received CNAME in reply")
 			p.watches.AddTemp(rr.Target, ttl)
+
+		case dns.TypeDNAME:
+			// DNAME record, store temporary watch
+			rr, ok := a.(*dns.DNAME)
+			if !ok {
+				log.Error("DNS-Proxy received invalid DNAME record in reply")
+				continue
+			}
+			log.WithFields(log.Fields{
+				"target": rr.Target,
+				"ttl":    ttl,
+			}).Debug("DNS-Proxy received DNAME in reply")
+			p.watches.AddTemp(rr.Target, ttl)
 		}
 	}
 

diff --git a/internal/dnsproxy/proxy_test.go b/internal/dnsproxy/proxy_test.go
@@ -69,11 +69,12 @@ func TestProxyHandleRequest(t *testing.T) {
 		reply := &dns.Msg{}
 		reply.SetReply(r)
 
+		dname, _ := dns.NewRR("test.example.com 3600 IN DNAME example.com.")
 		cname, _ := dns.NewRR("test.example.com 3600 IN CNAME example.com.")
 		a, _ := dns.NewRR("example.com. 3600 IN A 127.0.0.1")
 		aaaa, _ := dns.NewRR("example.com. 3600 IN AAAA ::1")
 
-		reply.Answer = []dns.RR{cname, aaaa, a}
+		reply.Answer = []dns.RR{dname, cname, aaaa, a}
 		if err := w.WriteMsg(reply); err != nil {
 			log.WithError(err).Error("error sending reply")
 		}