Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-header): added interfaces for type safety of navigation props #2044

Closed
wants to merge 10 commits into from

Conversation

ayeshaa-m
Copy link
Contributor

I have added interface variables as per code's analysis. Let me know if any field is missing. Kindly check for mandatory and non mandatory fields.

@ayeshaa-m ayeshaa-m linked an issue Jun 28, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit ce7af0d
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/65016e7ec2333b00084aaa6b
😎 Deploy Preview https://deploy-preview-2044--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@marvinLaubenstein marvinLaubenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 (As far as I can judge🤓)

Copy link
Collaborator

@felix-ico felix-ico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 i guess we just have to wait for the visual snapshots to update again 🥱

@acstll
Copy link
Collaborator

acstll commented Sep 13, 2023

More properly typing the footerNavigation props somehow breaks it (that's the reason for the visual tests breaking also… the navigation does not show).

@acstll acstll closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type-safe props in AppShell and AppHeader
4 participants