Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge main into release #2367

Merged
merged 27 commits into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
cdebdc6
docs: add angular 17 standalone reactive form sample
Jan 19, 2024
8a694a2
ci: sets up docker compose alias for compatibility (#2342)
amir-ba Aug 28, 2024
592c69d
fix: dropdown scroll fixed (#2333)
tshimber Aug 29, 2024
0b21978
chip accessibility fix (#2332)
tshimber Aug 29, 2024
318df56
checkbox and switch css fixes for high contrast mode (#2317)
tshimber Aug 29, 2024
168f710
ghost btn in storybook (#2341)
tshimber Aug 29, 2024
8681ed8
event part in storybook fixed (#2345)
tshimber Sep 19, 2024
2706542
aria details vs aria describedby fixed for text field (#2352)
tshimber Sep 19, 2024
3484ceb
chore(release): publish (#2354)
amir-ba Sep 19, 2024
1c98c49
data-grid extend localization (#2344)
tshimber Oct 10, 2024
d1209c5
no userInfo for profile-menu (#2339)
tshimber Oct 10, 2024
ee21b87
tag cell in data-grid extended (#2343)
tshimber Oct 16, 2024
f657202
feat(data-grid): adds presort to grid (#2335)
tshimber Oct 16, 2024
e0ff157
fix(button): Include name and value properties on temporary submit bu…
marcrobertscamao Oct 16, 2024
299be7d
fix(segment): improves loading of the component and solves nested ele…
amir-ba Oct 21, 2024
c7828c0
Merge branch 'docs/add-ng17-example'
Oct 23, 2024
6e8c380
fix(nav-item): hover underline on function slots (#2260)
felix-ico Oct 24, 2024
30a0ce5
feat(data-grid): added tooltip and scale-icon in data-grid action cel…
felix-ico Oct 24, 2024
c19759f
doc: adds VS code support for Scale customElements (#2357)
amir-ba Oct 24, 2024
42a3b36
fix(data-grid): imporves pagination with 0 elements (#2316)
JuliaaaaH Oct 24, 2024
4c45650
feat: aria-details added to all input types (#2359)
tshimber Oct 29, 2024
bd30a6f
fix(tab-nav): fixes preselect logic in tabs with disabled attribute (…
tshimber Oct 29, 2024
9b02151
feat(accordion): allow collapsible to be individually expanded (#2263)
MeridianGH Nov 6, 2024
eeaecaf
feat(data-grid): add scale-selection event and enhance editable text …
amir-ba Nov 6, 2024
9ad38f7
chore(release): publish
Nov 6, 2024
1ec47c8
chore(release): publish (#2365)
amir-ba Nov 6, 2024
2df0519
Merge branch 'main' of https://github.com/telekom/scale
Nov 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/build-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,15 @@ jobs:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
with:
ref: ${{ github.head_ref }}
- uses: actions/setup-node@v3
with:
node-version: 16

- name: Set up Docker Compose alias
run: |
sudo touch /usr/bin/docker-compose
echo 'docker compose --compatibility "$@"' | sudo tee /usr/bin/docker-compose
sudo chmod +x /usr/bin/docker-compose

- name: Restore Lerna
id: yarn-cache
uses: actions/cache@v2
Expand Down
40 changes: 40 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,46 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [3.0.0-beta.154](https://github.com/amir-ba/scale/compare/v3.0.0-beta.152...v3.0.0-beta.154) (2024-11-06)


### Bug Fixes

* **button:** Include name and value properties on temporary submit button ([#2351](https://github.com/amir-ba/scale/issues/2351)) ([e0ff157](https://github.com/amir-ba/scale/commit/e0ff15764128fecc0a643d14e1ee01f64ab67d0f))
* **data-grid:** imporves pagination with 0 elements ([#2316](https://github.com/amir-ba/scale/issues/2316)) ([42a3b36](https://github.com/amir-ba/scale/commit/42a3b3699df5b361b63fc9c466461e2af61d67ed))
* **nav-item:** hover underline on function slots ([#2260](https://github.com/amir-ba/scale/issues/2260)) ([6e8c380](https://github.com/amir-ba/scale/commit/6e8c38027a861babd28e8925dcc5db1c87a4b05d))
* **segment:** improves loading of the component and solves nested elemnts sizing issue ([#2358](https://github.com/amir-ba/scale/issues/2358)) ([299be7d](https://github.com/amir-ba/scale/commit/299be7d00122ed34fcde07cff9e288e291e33318))
* **tab-nav:** fixes preselect logic in tabs with disabled attribute ([#2320](https://github.com/amir-ba/scale/issues/2320)) ([bd30a6f](https://github.com/amir-ba/scale/commit/bd30a6f2a187976ae85234b5f526537f68b3ea80))
* dropdown scroll fixed ([#2333](https://github.com/amir-ba/scale/issues/2333)) ([592c69d](https://github.com/amir-ba/scale/commit/592c69d00e4a50f7113973bc583dff19f1cc8979))


### Features

* **accordion:** allow collapsible to be individually expanded ([#2263](https://github.com/amir-ba/scale/issues/2263)) ([9b02151](https://github.com/amir-ba/scale/commit/9b021511c94e29e9644680afcb15236b96ab35b5))
* **data-grid:** add scale-selection event and enhance editable text field ([#2362](https://github.com/amir-ba/scale/issues/2362)) ([eeaecaf](https://github.com/amir-ba/scale/commit/eeaecaf461f014fb57c4ad14e3f279640b777c5f))
* aria-details added to all input types ([#2359](https://github.com/amir-ba/scale/issues/2359)) ([4c45650](https://github.com/amir-ba/scale/commit/4c45650e14eff01ef42525f08ba27c1c7b0f2109))
* **data-grid:** added tooltip and scale-icon in data-grid action cell ([#2308](https://github.com/amir-ba/scale/issues/2308)) ([30a0ce5](https://github.com/amir-ba/scale/commit/30a0ce5bdb8ca13d0c6a067894a0ee4aef6dd98b))
* **data-grid:** adds presort to grid ([#2335](https://github.com/amir-ba/scale/issues/2335)) ([f657202](https://github.com/amir-ba/scale/commit/f6572021489ae07914dbbb6d31cb0aa2d20ea74c))






# [3.0.0-beta.153](https://github.com/amir-ba/scale/compare/v3.0.0-beta.152...v3.0.0-beta.153) (2024-09-19)


### Bug Fixes

* dropdown scroll fixed ([#2327](https://github.com/scale/issues/2327)) ([6f326eb](https://github.com/telekom/scale/commit/6f326eb138eff93080d39b1c74d48d9393fd1684))
* chip accessibility fix ([#2328](https://github.com/telekom/scale/issues/2328)) ([0b21978](https://github.com/telekom/scale/commit/0b21978bad9516d9958aa61e733a3f8348d11799))
* checkbox and switch css fixes for high contrast mode ([#2300](https://github.com/scale/issues/2300)) ([318df56](https://github.com/telekom/scale/commit/318df5658a21b7eea44abe37eba1fc6bedfc243c))
* ghost btn in storybook ([#2312](https://github.com/scale/issues/2312)) ([168f710](https://github.com/telekom/scale/commit/168f710fedae9df7f08decb79066b14bd7f73d1e))
* update of event descriptions in storybook ([#2315](https://github.com/scale/issues/2315)) ([8681ed8](https://github.com/telekom/scale/commit/8681ed8d4f1cd08a756cf7e952e520df840c40b4))
* aria describedby added extended for other use cases in text field ([#2349](https://github.com/scale/issues/2349)) ([2706542](https://github.com/telekom/scale/commit/270654297695571068c894aee30178729f361833))



# [3.0.0-beta.152](https://github.com/telekom/scale/compare/v3.0.0-beta.151...v3.0.0-beta.152) (2024-07-10)


Expand Down
16 changes: 16 additions & 0 deletions examples/angular17-reactive-forms/.editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Editor configuration, see https://editorconfig.org
root = true

[*]
charset = utf-8
indent_style = space
indent_size = 2
insert_final_newline = true
trim_trailing_whitespace = true

[*.ts]
quote_type = single

[*.md]
max_line_length = off
trim_trailing_whitespace = false
2 changes: 2 additions & 0 deletions examples/angular17-reactive-forms/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
.angular
.vscode
27 changes: 27 additions & 0 deletions examples/angular17-reactive-forms/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Angular17ReactiveForms

This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 17.0.8.

## Development server

Run `ng serve` for a dev server. Navigate to `http://localhost:4200/`. The application will automatically reload if you change any of the source files.

## Code scaffolding

Run `ng generate component component-name` to generate a new component. You can also use `ng generate directive|pipe|service|class|guard|interface|enum|module`.

## Build

Run `ng build` to build the project. The build artifacts will be stored in the `dist/` directory.

## Running unit tests

Run `ng test` to execute the unit tests via [Karma](https://karma-runner.github.io).

## Running end-to-end tests

Run `ng e2e` to execute the end-to-end tests via a platform of your choice. To use this command, you need to first add a package that implements end-to-end testing capabilities.

## Further help

To get more help on the Angular CLI use `ng help` or go check out the [Angular CLI Overview and Command Reference](https://angular.io/cli) page.
96 changes: 96 additions & 0 deletions examples/angular17-reactive-forms/angular.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
{
"$schema": "./node_modules/@angular/cli/lib/config/schema.json",
"version": 1,
"newProjectRoot": "projects",
"projects": {
"angular17-reactive-forms": {
"projectType": "application",
"schematics": {},
"root": "",
"sourceRoot": "src",
"prefix": "app",
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:application",
"options": {
"outputPath": "dist/angular17-reactive-forms",
"index": "src/index.html",
"browser": "src/main.ts",
"polyfills": [
"zone.js"
],
"tsConfig": "tsconfig.app.json",
"assets": [
"src/favicon.ico",
"src/assets"
],
"styles": [
"src/styles.css",
"node_modules/@telekom/scale-components/dist/scale-components/scale-components.css"
],
"scripts": []
},
"configurations": {
"production": {
"budgets": [
{
"type": "initial",
"maximumWarning": "500kb",
"maximumError": "1mb"
},
{
"type": "anyComponentStyle",
"maximumWarning": "2kb",
"maximumError": "4kb"
}
],
"outputHashing": "all"
},
"development": {
"optimization": false,
"extractLicenses": false,
"sourceMap": true
}
},
"defaultConfiguration": "production"
},
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"buildTarget": "angular17-reactive-forms:build:production"
},
"development": {
"buildTarget": "angular17-reactive-forms:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"buildTarget": "angular17-reactive-forms:build"
}
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"options": {
"polyfills": [
"zone.js",
"zone.js/testing"
],
"tsConfig": "tsconfig.spec.json",
"assets": [
"src/favicon.ico",
"src/assets"
],
"styles": [
"src/styles.css"
],
"scripts": []
}
}
}
}
}
}
39 changes: 39 additions & 0 deletions examples/angular17-reactive-forms/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"name": "angular17-reactive-forms",
"version": "0.0.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"watch": "ng build --watch --configuration development",
"test": "ng test"
},
"private": true,
"dependencies": {
"@angular/animations": "^17.0.0",
"@angular/common": "^17.0.0",
"@angular/compiler": "^17.0.0",
"@angular/core": "^17.0.0",
"@angular/forms": "^17.0.0",
"@angular/platform-browser": "^17.0.0",
"@angular/platform-browser-dynamic": "^17.0.0",
"@angular/router": "^17.0.0",
"@telekom/scale-components": "^3.0.0-beta.147",
"rxjs": "~7.8.0",
"tslib": "^2.3.0",
"zone.js": "~0.14.2"
},
"devDependencies": {
"@angular-devkit/build-angular": "^17.0.8",
"@angular/cli": "^17.0.8",
"@angular/compiler-cli": "^17.0.0",
"@types/jasmine": "~5.1.0",
"jasmine-core": "~5.1.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"typescript": "~5.2.2"
}
}
Empty file.
66 changes: 66 additions & 0 deletions examples/angular17-reactive-forms/src/app/app.component.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
<!-- * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * -->
<!-- * * * * * * * * * * * The content below * * * * * * * * * * * -->
<!-- * * * * * * * * * * is only a placeholder * * * * * * * * * * -->
<!-- * * * * * * * * * * and can be replaced. * * * * * * * * * * -->
<!-- * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * -->
<!-- * * * * * * * * * Delete the template below * * * * * * * * * -->
<!-- * * * * * * * to get started with your project! * * * * * * * -->
<!-- * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * -->

<style>
:host {
display: flex;
padding: 1rem;
width: 100%;
justify-content: center;
}
</style>

<main class="main">
<form [formGroup]="signupForm" (ngSubmit)="onSubmit()">
<p>
<scale-text-field label="Username" formControlName="username"></scale-text-field>
</p>

<p>
<scale-text-field label="Password" formControlName="password" type="password"></scale-text-field>
</p>
<p>
<scale-checkbox label="I agree with the privacy policy" formControlName="consent"></scale-checkbox>
</p>
<p>
<scale-dropdown-select label="select" formControlName="select">
<scale-dropdown-select-item value="foo">Foo</scale-dropdown-select-item>
<scale-dropdown-select-item value="bar">Bar</scale-dropdown-select-item>
</scale-dropdown-select>
</p>

<p>
<scale-date-picker
label="Standard"
value="2020-12-31"
placeholder="Select date"
formControlName="date"
ngDefaultControl
></scale-date-picker>
</p>
<label for="name">Name: </label>
<scale-button type="submit">console.log</scale-button>
<scale-button type="reset" variant="secondary">Reset</scale-button>
</form>
<scale-card>
<pre>{{ signupForm.value | json }}</pre>
</scale-card>

</main>

<!-- * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * -->
<!-- * * * * * * * * * * * The content above * * * * * * * * * * * * -->
<!-- * * * * * * * * * * is only a placeholder * * * * * * * * * * * -->
<!-- * * * * * * * * * * and can be replaced. * * * * * * * * * * * -->
<!-- * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * -->
<!-- * * * * * * * * * * End of Placeholder * * * * * * * * * * * * -->
<!-- * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * -->


<router-outlet></router-outlet>
29 changes: 29 additions & 0 deletions examples/angular17-reactive-forms/src/app/app.component.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { TestBed } from '@angular/core/testing';
import { AppComponent } from './app.component';

describe('AppComponent', () => {
beforeEach(async () => {
await TestBed.configureTestingModule({
imports: [AppComponent],
}).compileComponents();
});

it('should create the app', () => {
const fixture = TestBed.createComponent(AppComponent);
const app = fixture.componentInstance;
expect(app).toBeTruthy();
});

it(`should have the 'angular17-reactive-forms' title`, () => {
const fixture = TestBed.createComponent(AppComponent);
const app = fixture.componentInstance;
expect(app.title).toEqual('angular17-reactive-forms');
});

it('should render title', () => {
const fixture = TestBed.createComponent(AppComponent);
fixture.detectChanges();
const compiled = fixture.nativeElement as HTMLElement;
expect(compiled.querySelector('h1')?.textContent).toContain('Hello, angular17-reactive-forms');
});
});
33 changes: 33 additions & 0 deletions examples/angular17-reactive-forms/src/app/app.component.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { Component, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
import { CommonModule } from '@angular/common';
import { RouterOutlet } from '@angular/router';
import { ReactiveFormsModule, FormGroup, FormControl, UntypedFormControl } from '@angular/forms';
import { CheckedValueAccessorDirective } from '../directives/checked-value-accessor';
import { DateValueAccessorDirective } from '../directives/date-value-accessor';
import { SelectValueAccessorDirective } from '../directives/select-value-accessor';
import { NumberValueAccessorDirective } from '../directives/number-value-accessor';
import { RadioValueAccessorDirective } from '../directives/radio-value-accessor';
import { TextValueAccessorDirective } from '../directives/text-value-accessor';
@Component({
selector: 'app-root',
standalone: true,
imports: [CommonModule, RouterOutlet, ReactiveFormsModule, CheckedValueAccessorDirective, DateValueAccessorDirective, SelectValueAccessorDirective,TextValueAccessorDirective, RadioValueAccessorDirective, NumberValueAccessorDirective ],
schemas: [CUSTOM_ELEMENTS_SCHEMA], // Telekom Scale
templateUrl: './app.component.html',
styleUrl: './app.component.css'
})
export class AppComponent {
title = 'angular17-reactive-forms';
signupForm = new FormGroup({
username: new UntypedFormControl('admin'),
password: new UntypedFormControl({ value: '', disabled: false }),
consent: new UntypedFormControl(),
select: new UntypedFormControl('foo'),
date: new UntypedFormControl(),
});


onSubmit() {
console.log('submitting ->', this.signupForm.value, this.signupForm);
}
}
8 changes: 8 additions & 0 deletions examples/angular17-reactive-forms/src/app/app.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { ApplicationConfig } from '@angular/core';
import { provideRouter } from '@angular/router';

import { routes } from './app.routes';

export const appConfig: ApplicationConfig = {
providers: [provideRouter(routes)]
};
3 changes: 3 additions & 0 deletions examples/angular17-reactive-forms/src/app/app.routes.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { Routes } from '@angular/router';

export const routes: Routes = [];
Empty file.
Loading
Loading