Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use teleport packages for code-embed and date-time primitive #810

Open
wants to merge 83 commits into
base: development
Choose a base branch
from

Conversation

ionutpasca
Copy link
Member

No description provided.

pascaionut12345 and others added 30 commits March 15, 2023 20:14
Add the possibility for each page to define resources for static paths and props
Add support for fetch requests and nextjs static paths and props
* Add support for pagination on static paths/props

* Small changes in cms project uidl

---------

Co-authored-by: Ionut Pasca <[email protected]>
Add support for CMS list and CMS item inside nextjs generators
* Changes required for contentful support

* Small changes

* Add possibility to use mapper functions for cms list/items & initialProps (#767)

Co-authored-by: Ionut Pasca <[email protected]>

---------

Co-authored-by: Ionut Pasca <[email protected]>
* Progress so far

* Progress so far

* aRemove type cast that was unnecesarry

* A better example

* Feat/contentful richtext (#768)

* Support for dynamic attributes from ctx

* Test and fix for contentful richtext node

* Remove console.log

* We dont use package.lock

* Bring back standalone

---------

Co-authored-by: Eliza Nitoi <[email protected]>
Co-authored-by: Ionut Pasca <[email protected]>
* Allow static values on component seo and meta tags

* Small change

---------

Co-authored-by: Ionut Pasca <[email protected]>
* Subselector support for classes

* Add explanation for &

* Support states and MQs for subselector classes as well
JayaKrishnaNamburu and others added 25 commits May 22, 2023 19:08
…gs (#795)

* normalization of UIDL and new changes for resource mappings

* Add support for cms-list using api and plugins

* Combine next and react fetch plugins into one

* Allow trace for logs

* Ability to handle cms-item and make the request post only when needed

* Add params only when needed in next apis

* Make mappers configurable and fix all the tests
* (feat): Add response type for resources

* Add explanation for AST resposnse
@@ -32,7 +33,7 @@ export const PlainHTMLMapping: Mapping = {
meta: {
importJustPath: true,
importAlias:
'https://github.com/teleporthq/date-time-primitive/blob/main/dist/default/lib.umd.js',
'https://unpkg.com/@teleporthq/[email protected]/dist/thq-lit-components.umd.js',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ionutpasca we can use single repo to maintain all 3 frameworks. As vite can build all three at the same time. As the changes always need to be in sync with all the three flavours. That makes it less confusing while maintaining too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I spoke with vladut. We can keep them seperately. But, let's map these URL's to independent umd builds. Instead of loading all of them 👍

meta: {
importJustPath: true,
importAlias: 'https://unpkg.com/[email protected]/dist/default/lib.umd.js',
importAlias:
'https://unpkg.com/@teleporthq/[email protected]/dist/thq-lit-components.umd.js',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we need to improve this, or else if we are using just dangerous-html. It installs the date-time-primitive too even if we are not using. Since these are umd builds. The bundlers can't tree shake them

@JayaKrishnaNamburu JayaKrishnaNamburu self-requested a review July 6, 2023 17:34
@JayaKrishnaNamburu
Copy link
Member

I will take care of this @ionutpasca. I would like to change the build system a little for the lit components. So they can be loaded the components on demand. Instead of all of them 👍

Base automatically changed from feat/better-fetch to development January 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants