Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(chart): add a11y yml file #1855

Merged
merged 8 commits into from
Jan 15, 2024
Merged

docs(chart): add a11y yml file #1855

merged 8 commits into from
Jan 15, 2024

Conversation

dimodi
Copy link
Contributor

@dimodi dimodi commented Jan 11, 2024

No description provided.

@dimodi dimodi requested a review from a team January 11, 2024 15:06
@dimodi dimodi marked this pull request as ready for review January 12, 2024 15:32
@dimodi dimodi requested a review from a team as a code owner January 12, 2024 15:32
ikoevska
ikoevska reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@ikoevska ikoevska left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that a fix to the template for generating these pages is needed. I have also noted it in #1839

@dimodi
Copy link
Contributor Author

dimodi commented Jan 15, 2024

Note that a fix to the template for generating these pages is needed. I have also noted it in #1839

Yes, here is the PR: https://github.com/telerik/web-components-ux/pull/968

@dimodi dimodi requested a review from ikoevska January 15, 2024 07:50
ikoevska
ikoevska reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@ikoevska ikoevska left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the link issue still stands. Please, ping me when the PR to the template gets fixed and the article is re-generated.

There are two ways to go about this:

Option A) We merge as is. After all, all other accessibility articles have the same issue. We then re-generate after the PR to the template gets merged.
Option B) We delay the merge until the PR to the template gets fixed. However, this will probably result in every wai-aria page getting re-generated as well. (It might be better to see this in a separate PR for history purposes though).

It depends on how urgent this a11y article is. If urgent, I am inclined to get this merged as is, if we get a tracking issue for re-generating content once the template is fixed.

@dimodi
Copy link
Contributor Author

dimodi commented Jan 15, 2024

This PR contains a fix, which will affect another PR for the TreeList, so we will merge it and take care of the re-generation.

@dimodi dimodi merged commit 5613618 into master Jan 15, 2024
@github-actions github-actions bot deleted the chart-a11y-yml branch January 15, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikoevska ikoevska ikoevska left review comments

@xristianstefanov xristianstefanov xristianstefanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimodi @ikoevska @xristianstefanov @kendo-bot