docs(Chat): improve examples to follow style guide #3236
+361
−211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanDanchev
added
the
merge-to-production
|
Hello @IvanDanchev, Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.
|
dimodi
reviewed
Sep 16, 2025
|
|
||
| public class ChatMessage | ||
| { | ||
| public string Id { get; set; } | ||
|
|
There was a problem hiding this comment.
We normally don't use empty lines in classes to keep the code snippets shorter.
dimodi
reviewed
Sep 16, 2025
|
|
||
| private List<string> QuickReplies = new List<string> | ||
| @code { | ||
| private TelerikChat<ChatMessage> ChatRef { get; set; } |
There was a problem hiding this comment.
Nullable references are enabled by default in new .NET apps. Our code snippets should not trigger compiler warnings about possible null values.
Suggested change
| private TelerikChat<ChatMessage> ChatRef { get; set; } | |
| private TelerikChat<ChatMessage>? ChatRef { get; set; } |
dimodi
reviewed
Sep 16, 2025
| @@ -57,6 +57,7 @@ Configure file upload behavior using the `ChatFileSelectSettings` component: | |||
|
|
|||
| @code { | |||
| private TelerikChat<ChatMessage> Chat1; | |||
There was a problem hiding this comment.
Should be, with the corresponding ? or ! in method calls.
Suggested change
| private TelerikChat<ChatMessage> Chat1; | |
| private TelerikChat<ChatMessage>? ChatRef { get; set; } |
dimodi
reviewed
Sep 16, 2025
| private List<ChatMessage> Messages { get; set; } = new List<ChatMessage> | ||
| #region Component Parameters | ||
|
|
||
| private List<ChatMessage> ChatData { get; set; } |
There was a problem hiding this comment.
Should be
Suggested change
| private List<ChatMessage> ChatData { get; set; } | |
| private List<ChatMessage> ChatData { get; set; } = new(); |
or
Suggested change
| private List<ChatMessage> ChatData { get; set; } | |
| private List<ChatMessage>? ChatData { get; set; } |
dimodi
approved these changes
Sep 16, 2025
ikoevska
reviewed
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to external contributors: make sure to sign our Contribution License Agreement (CLA) for Blazor UI first:
https://forms.office.com/Pages/ResponsePage.aspx?id=Z2om2-DLJk2uGtBYH-A1NbWxVqugKN5DvVp8I-1AgOBURFBVSkwyMlA1TkFDVFdMNU1aM1o1UlZQOC4u