Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: resolve husky deprecation warnings #383

Merged
merged 1 commit into from
Sep 3, 2024
Merged

chore: resolve husky deprecation warnings #383

merged 1 commit into from
Sep 3, 2024

Conversation

epetrow
Copy link
Contributor

@epetrow epetrow commented Sep 3, 2024

No description provided.

@epetrow epetrow requested a review from a team as a code owner September 3, 2024 14:40
@epetrow epetrow self-assigned this Sep 3, 2024
@epetrow epetrow merged commit b50463f into develop Sep 3, 2024
1 check passed
@epetrow epetrow deleted the husky-deprecation-warnings branch September 3, 2024 15:01
Juveniel
Juveniel reviewed Sep 4, 2024
View reviewed changes
package.json
@@ -7,7 +7,7 @@
"packages/svg-icons"
],
"scripts": {
"setup": "npm install && npx husky install",
"setup": "npm install && npx husky",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this to the "prepare" script, as this will automatically setup husky when you do a npm ci. See ref.

You can also remove the "setup" script, as the repo setup now will consist of just running npm ci :)

@epetrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juveniel Juveniel Juveniel left review comments

@zhpenkov zhpenkov zhpenkov approved these changes

Assignees

@epetrow epetrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epetrow @Juveniel @zhpenkov