-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore): implement motion system #4779
Draft
epetrow
wants to merge
8
commits into
develop
Choose a base branch
from
motion-system
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e6bb87
to
e80a7a1
Compare
7d8f658
to
459f8bf
Compare
c05ca7c
to
a69702c
Compare
Please rename all commits implement motion system and i_ntegrate motion system_ per theme to feat, not chore.(Also remove the WIP). |
inikolova
reviewed
Dec 18, 2023
inikolova
reviewed
Dec 18, 2023
inikolova
reviewed
Dec 18, 2023
inikolova
reviewed
Dec 18, 2023
inikolova
reviewed
Dec 18, 2023
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
inikolova
reviewed
Jan 15, 2024
98e2a84
to
a94073a
Compare
a94073a
to
6d772f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/telerik/kendo-themes-private/issues/103
Below is a short breakdown of the motion system implementation and how it works:
1. Motion Durations and Easings:
$_default-motion-durations
: Defines a map of motion duration tokens with, each associated with a specific duration in seconds.$_default-motion-easings
: Defines a map of motion easing tokens (timing functions), each associated with a cubic-bezier function.$kendo-motion-durations
and$kendo-motion-easings
: These variables store the default motion durations and easings, but can be customized by the user.2.
k-motion
:Accepts a duration, timing function, and a list of properties.
Generates a CSS transition property for each property with the specified duration and timing function.
Checks if transitions are enabled (
$kendo-enable-transitions
), if not sets transition-duration to 0s.3.
kendo-motion
:k-motion
function to generate thetransition
property for a set of CSS properties.4. Usage:
Motion durations and easings can be customized by overriding or defining values for
$kendo-motion-durations
and$kendo-motion-easings
variables.Applying transitions to specific properties. For example: