Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes in this PR:
1. Update the SDK from netcoreapp2.1 to net8.0
This is done for both security and modernization considerations. After upgrading the SDK, some changes to how the routing is configured in Program and Startup is required. some highlights
app.MapHub<T>
AddCors()
does not support the use of both wildcards andAllowCredentials()
at the same time. this is a read-only hub, so we can remove AllowCredentials.builder.Services.AddDbContext
)2. General housekeeping and modern C# expectations
There was a lot of C# 8 and C# 9 code. I cleaned this up a bit by using cleaner C# 10 considerations. Here are the results of the improvement.
IWebHostEnvironment
intoSampleEntitiesDataContext
to get App_Data directory's path3. Testing
I've confirmed the SignalR service itself is running and operates as expected, however we should briefly test it using one of our real demos that consume the service.