Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace images with TinyPNG optimized version #932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Replace images with TinyPNG optimized version #932

wants to merge 1 commit into from

Conversation

pepinho24
Copy link

Related to the PageSpeed optimization effort telerik/docs-seed#124

The images have been optimized to be smaller in size. I propose that you build and test this branch to see if the images in the docs look good and if so - then merge and go live.

@LanceMcCarthy
Copy link
Collaborator

This PR is outdated now that we have replaced images of the icons with an HTML table containing copy-pastable text.

@didiyordanova do you concur? If yes, lets close this PR/branch.

@pepinho24
Copy link
Author

The PR has all the existing images in the repository optimized and with some meta data in them to prevent double optimization from the future docs-seed tool. I can rework the PR and create a new one that only changes the old images that were not changed/remove after this PR.

@LanceMcCarthy
Copy link
Collaborator

Sorry, I just realized that this PR contains TinyPng updates for all the images in the docs 🤣 A quick master pull should resolve the last 3 conflicts and grab any new images since July.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants