Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to terraform 0.12 #13

Merged
merged 14 commits into from
Jul 2, 2019
Merged

Upgrade to terraform 0.12 #13

merged 14 commits into from
Jul 2, 2019

Conversation

itsdalmo
Copy link
Contributor

@itsdalmo itsdalmo commented Jul 2, 2019

The only breaking change here should be tags {} becoming tags = {} (terraform 0.12's fault), and the workarounds for instance_policy and user_data being fixed. I think that is a good start, and then we can do more drastic stuff afterwards.

Since terraform 0.12 makes it easier to provide default values/behavior, and expose values, I think it makes sense to do breaking changes later:

But should perhaps include the following changes in this PR:

  • Switch to Taskfile instead of Makefile
  • Use terratest to run integration tests?

@itsdalmo itsdalmo changed the title Run terraform 0.12upgrade Upgrade to terraform 0.12 Jul 2, 2019
@itsdalmo itsdalmo marked this pull request as ready for review July 2, 2019 13:41
@itsdalmo itsdalmo requested a review from a team as a code owner July 2, 2019 13:41
Copy link
Contributor

@mikael-lindstrom mikael-lindstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@itsdalmo itsdalmo merged commit 4f55b85 into master Jul 2, 2019
@itsdalmo itsdalmo deleted the 0.12upgrade branch July 2, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants