Remove cloudformation depedency #26
Conversation
Signed-off-by: Max Knee <[email protected]>
|
Hey @maxknee - the reason we use CloudFormation for the autoscaling groups is because CF has a built-in support for e.g. rolling updates, and resources can signal when they are ready (and not just passing EC2 healthchecks) to avoid downtime. Any particular reason you want/need to get rid of the CF here? |
create_before_destory` and having `wait_for_elb_capacity` achieves the `rollingUpdates` without the cloudformation. Signed-off-by: Max Knee <[email protected]>
|
https://www.terraform.io/docs/providers/aws/r/autoscaling_group.html#wait_for_capacity_timeout |
|
Waiting for capacity will either wait for an EC2 or ELB health check, but for "worker" instances the instance might not be attached to an ELB, and the EC2 health check might pass before the instances is ready to accept work. For example with ECS clusters, the instance itself is not attached to any load balancers (the containers are) and you don't want to signal that you are ready before the ECS agent has started. Unfortunately I think the only way to support this (and similar) use case is by using Cloudformation and |
|
I am thinking of another way for it to access traffic to signal workers are healthy in the respects of concourse. ASGs do rolling updates with launch configs, IIRC |
Moving to use ASG resource instead of cloudformation
#11
Signed-off-by: Max Knee [email protected]