Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message to show oracle contract for chainId on start #713

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

0xSpuddy
Copy link
Contributor

@0xSpuddy 0xSpuddy commented Oct 18, 2023

Summary

This pull request will add the oracle contract address as part of the config info that Telliot shows at startup. This helps reporters check that they're not accidentally staking on an old oracle contract.

This pull request is:

  • A feature implementation

@0xSpuddy
Copy link
Contributor Author

@akremstudy Tox Typing was failing on bitfinex.py so I copied the fix from #712 hope that's ok

@0xSpuddy
Copy link
Contributor Author

0xSpuddy commented Oct 18, 2023

@akremstudy should have just merged your PR first. Reverted that commit, so it should be good now if the code is ok.

Copy link
Collaborator

@akremstudy akremstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @0xSpuddy.

@akremstudy akremstudy merged commit 9655fb6 into main Oct 19, 2023
4 checks passed
@akremstudy akremstudy deleted the show-oracle-address branch October 19, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants