Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect path of missing/wrong headers #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

redirect path of missing/wrong headers #22

wants to merge 5 commits into from

Conversation

selkfoster
Copy link

@selkfoster selkfoster commented Aug 9, 2017 •
edited
Loading

No description provided.

@selkfoster
redirect <sys/fcntl.h> to <fcntl.h> as the GCC compiler suggest
c26a6e1 
gcc  -I/usr/src/gpm-1.20.7/src -DHAVE_CONFIG_H -include headers/config.h -Wall -DSYSCONFDIR="\"/etc\"" -DSBINDIR="\"/usr/sbin\"" -D_GNU_SOURCE  -g -O2  -c -o daemon/gpm.o daemon/gpm.c
In file included from daemon/gpm.c:32:0:
/usr/include/sys/fcntl.h:1:2: warning: #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h> [-Wcpp]
@selkfoster
Change path for missing headers of some progs/*.c
54651a0 
Previously:

for DEPS in `echo *.c */*.c`; do \
gcc -I. -I /usr/src/gpm-1.20.7/src -M  -I/usr/src/gpm-1.20.7/src -DHAVE_CONFIG_H -include headers/config.h -Wall -DSYSCONFDIR="\"/etc\"" -DSBINDIR="\"/usr/sbin\"" -D_GNU_SOURCE  $DEPS | \
/bin/sed 's/^\(.*\)\.o\([ :]+\)/\1.o \1.lo\2/g' >> .depend ; done
prog/display-buttons.c:39:57: fatal error: gpm.h: No such file or directory
 #include <gpm.h>              /* gpm information      */
                                                         ^
compilation terminated.
prog/display-coords.c:40:57: fatal error: gpm.h: No such file or directory
 #include <gpm.h>              /* gpm information      */
                                                         ^
compilation terminated.
prog/get-versions.c:25:57: fatal error: gpm.h: No such file or directory
 #include <gpm.h>              /* gpm information      */
                                                         ^
compilation terminated.
@selkfoster selkfoster changed the title redirect <sys/fcntl.h> to <fcntl.h> as the GCC compiler suggest redirect path of missing/wrong headers Aug 9, 2017
@selkfoster selkfoster mentioned this pull request Sep 26, 2019
Open
@darko-poljak
Copy link
Collaborator

@selkfoster Can you resolve conflicts? Thanks!

@selkfoster
Copy link
Author

@darko-poljak Hello. Yes, I will make the update, tomorrow (due to the lack of time now).

@selkfoster
Copy link
Author

@darko-poljak Done. :-)

selkfoster
selkfoster commented Jun 19, 2020
View reviewed changes
Copy link
Author

@selkfoster selkfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove conflict requested by @darko-poljak from Pull Request #22

@selkfoster
Copy link
Author

selkfoster commented Sep 3, 2020 •
edited
Loading

UPDATE:

It looks like gpm does not build without the fcntl.h header:

lib/liblow.c: In function 'Gpm_Open':
lib/liblow.c:265:29: warning: implicit declaration of function 'open'; did you mean 'popen'? [-Wimplicit-function-declaration]
265 | if ((gpm_consolefd=open(tty,O_WRONLY)) < 0) {
| ^~~~
| popen
lib/liblow.c:265:38: error: 'O_WRONLY' undeclared (first use in this function)
265 | if ((gpm_consolefd=open(tty,O_WRONLY)) < 0) {
| ^~~~~~~~
lib/liblow.c:265:38: note: each undeclared identifier is reported only once for each function it appears in
lib/liblow.c:328:41: error: 'O_RDWR' undeclared (first use in this function)
328 | if ((gpm_fd=open(GPM_NODE_DEV,O_RDWR))==-1) {
| ^~~~~~
make[1]: *** [Makefile:71: lib/liblow.lo] Error 1
make[1]: Leaving directory '/usr/src/qi/build/gpm-20200617_e82d1a6/src'
make: *** [Makefile:77: do-all] Error 1

Looks like we can ignore and close this PR.

P.S: I am testing and building the latest source from the -master branch (17 Jun). Seems to be working fine.

@sergiomb2
Copy link

sergiomb2 commented Feb 16, 2021 •
edited
Loading

this should be fixed, the issue with headers with #14 in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@selkfoster @darko-poljak @sergiomb2