Fix the deserialization of some get_account responses
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the conditional configuration of tests - Split the account deserialization test into 3 smaller tests - Switched to raw strings to keep JSON formatting and make the content more readable
The deserialization of the `core_liquid_balance` wasn't taking into account that such field could be omitted.
ptagl
changed the title
get_account responsesget_account responses
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some fixes to prevent the crash of
antelope-rsduring the deserialization of someget_accountresponses. The affected fields are:AccountVoterInfo/last_stakeAccountResourceLimit/availableAccountResourceLimit/maxAccountObject/core_liquid_balanceSome unit tests have been added to cover these edge cases.