Development >> Master #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks for rscdk compiled contracts" This reverts commit 6977b8b, in particular the endianness of Checksum256. This is needed to be compatible with the C++ smart contracts compiler, while rscdk (Rust WASM compiler) needs the commit that here is being reverted. This means that going on antelope-rs will be compatible with the C++ smart contracts compiler and not with the Rust compiler.
The test was meant to check the consistency of the Checksum256 encoding with the SNARKtor contracts and the WASM-compiled smart contracts in general. However, given that the `rscdk` compiler treats the encoding of Checksum256 with a different encoding compared to the C++ compiler, the test has been removed. It could be restored once the `rscdk` issue is fixed.
- Added the conditional configuration of tests - Split the account deserialization test into 3 smaller tests - Switched to raw strings to keep JSON formatting and make the content more readable
The deserialization of the `core_liquid_balance` wasn't taking into account that such field could be omitted.
Fix the deserialization of some `get_account` responses This PR includes some fixes to prevent the crash of antelope-rs during the deserialization of some get_account responses. The affected fields are: - AccountVoterInfo/last_stake - AccountResourceLimit/available - AccountResourceLimit/max - AccountObject/core_liquid_balance Some unit tests have been added to cover these edge cases.
Add timeout
Support for encode/decode of Webauthn (WA) type signatures
Response decoding fix for inconsistent types
In order to avoid duplicate runs, the trigger has now been set to activate when a new push within a PR targeting the `development` branch is detected.
[CI] Added `--all-targets` as parameter of `cargo clippy`
* Changes for ship reading * Adding support for other index types on next_key * Fix ABI encoding, better handle secondary index table queries * WIP - Complete GetTableRowsParams to_json functionality * Switch endian order for Checksum256 index, only works for rscdk compiled contracts * Some changes to deseralize blocks * Disable TrxVarient on get block response for now * Fix mock provider data * formatter and clippy pass * Partially revert "Switch endian order for Checksum256 index, only works for rscdk compiled contracts" This reverts commit 6977b8b, in particular the endianness of Checksum256. This is needed to be compatible with the C++ smart contracts compiler, while rscdk (Rust WASM compiler) needs the commit that here is being reverted. This means that going on antelope-rs will be compatible with the C++ smart contracts compiler and not with the Rust compiler. * Removed `secondary_index` test The test was meant to check the consistency of the Checksum256 encoding with the SNARKtor contracts and the WASM-compiled smart contracts in general. However, given that the `rscdk` compiler treats the encoding of Checksum256 with a different encoding compared to the C++ compiler, the test has been removed. It could be restored once the `rscdk` issue is fixed. * Removed commented code * Add tracing logging instead of println. * Remove debug flag. * fmt. * Rollback default provided implementation. * Remove prints for the tests. * Fix compile after merge. --------- Co-authored-by: Jesse Schulman <[email protected]> Co-authored-by: Guillermo Rodriguez <[email protected]> Co-authored-by: Paolo Tagliaferri <[email protected]> Co-authored-by: lesa-telos <[email protected]>
ptagl
approved these changes
Oct 16, 2024
MarcoOl94
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.