#754 | Crosschain - Step Two: replace all env variables for chainsettings properties #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Master into Dev.
…sactions bugfix - avoid using null contract
…connection-after-refresh-if-user-refused-to-connect-once #715 | fix Metamask popup problem
…let' of https://github.com/telosnetwork/teloscan into 754-crosschain--replace-all-env-variables-for-chainsettings-properties
#737 | workaround for the NaN age + fix false values not showing
…w-contract-function-call #747 | decode trx input to show contract function call
…d-message-display-bug #739 | TransactionAction cases: Function call, TLOS transfer, Contract Creation
…eview-image-on-click-1 #740 | Popup Image viewer for NFTs
✅ Deploy Preview for testnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #754
This PR is included in the final PR for this same EPIC (that's why is in draft)
Description
This PR replaces all chain-specific variables from the environment to the chain settings classes. Also, all the code was adapted to take the values from the chain settings instead of the environment variables.
No functionalities were changed.