Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed persistent state with outdated data + updated Bincode docs #1187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LasterAlex
Copy link
Collaborator

Fixes #1156 and closes #1155

I don't consider it a breaking change. If someone is relying on outdated data in redis to filter old users... What?..

And i do think it is necessary, because otherwise the user with the broken state is just softlocked forever

@teloxidebot
Copy link
Collaborator

r? @hirrolot

(teloxidebot has picked a reviewer for you, use r? to override)

@teloxidebot teloxidebot added A-dialogue Area: dialogue system A-dispatching Area: dispatching updates (`Dispatcher`, repls) C-main crate: teloxide S-waiting-on-review Status: Awaiting review from the assignee labels Oct 20, 2024
@hirrolot hirrolot self-requested a review October 22, 2024 00:20
@LasterAlex
Copy link
Collaborator Author

Hm, maybe it's also good to make something like .enter_dialogue_or(async |u: Update| {...})? For the ability to say "Sorry, bot updated, resetting your state..." or smth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dialogue Area: dialogue system A-dispatching Area: dispatching updates (`Dispatcher`, repls) C-main crate: teloxide S-waiting-on-review Status: Awaiting review from the assignee
Projects
None yet
3 participants