More timestamp improvements #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icRefCell instead of Mutex
Audio/video are in practice not always from the same clock and can have different behaviours with regards to clock rate and jitter. Handling them separately generally gives better results for the timestamps output by the source element.
- NDI HX Camera Android in the past used 1ns instead of 100ns as unit for timecodes/timestamps. - NDI HX Camera iOS uses 0 for all timecodes and the same non-zero value for all audio timestamps Detect such situations and try to compensate for them. Also add a new "auto" timestamping mode that prefers to use timecodes and otherwise falls back to timestamps or receive times. Fixes teltek#79
|
This pull request also fixes a problem that I noticed, where by using the source and sink pipelines specified in the |
|
That's probably the 3rd commit |
|
I've pulled this down and tested it and it helps with some problematic NDI sources using gstreamer, specifically the NDI camera app on an iphone seems to work well using the |
When using the Advanced SDK it is possible to output compressed formats too.
Open
|
This is merged here now: https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/tree/main/net/ndi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
CC @samuvlad @pnieto