Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/optimize image #477

Merged
merged 9 commits into from
Apr 15, 2021
Merged

Feat/optimize image #477

merged 9 commits into from
Apr 15, 2021

Conversation

kiesha-telus
Copy link
Contributor

@kiesha-telus kiesha-telus commented Apr 7, 2021

Related issues

See related issue: #439

Description

Component optimizes images to render by modifying Contentful asset urls. Detects browser support for webp format and converts the image to this format for faster load time. Sizes images according to screen width to further help reduce image file size at load time.

Checklist before submitting pull request

  • Commits follow our Developer Guide
  • New code is unit tested
  • make sure visual and accessibility tests pass
  • make sure code builds

@TDSBot
Copy link

TDSBot commented Apr 7, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@TDSBot
Copy link

TDSBot commented Apr 7, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

Copy link
Contributor

@jraff jraff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please remove shared/utils/generateId/package-lock.json
  2. Why are there updates to the Tabs and Tags snapshots?

packages/OptimizeImage/OptimizeImage.md Outdated Show resolved Hide resolved
@TDSBot
Copy link

TDSBot commented Apr 8, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@kiesha-telus
Copy link
Contributor Author

the Tabs/Modal snapshots were updated because the tds-core package for core-interactive-icon was updated. let me know if i should revert this

@mike-bunce mike-bunce merged commit b2c6917 into master Apr 15, 2021
@kiesha-telus kiesha-telus deleted the feat/optimize-image branch April 15, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants