-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/optimize image #477
Merged
Merged
Feat/optimize image #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jraff
requested changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please remove
shared/utils/generateId/package-lock.json
- Why are there updates to the Tabs and Tags snapshots?
|
the Tabs/Modal snapshots were updated because the tds-core package for core-interactive-icon was updated. let me know if i should revert this |
Andrew-K-Lam
requested changes
Apr 9, 2021
Andrew-K-Lam
approved these changes
Apr 13, 2021
jraff
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
See related issue: #439
Description
Component optimizes images to render by modifying Contentful asset urls. Detects browser support for webp format and converts the image to this format for faster load time. Sizes images according to screen width to further help reduce image file size at load time.
Checklist before submitting pull request