chore(other): update git ignore, add safer node sass build

telus · Jan 31, 2019 · 08c6c1b · 08c6c1b
1 parent cf705f4
commit 08c6c1b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -19,6 +19,7 @@ coverage
 dist/
 guide/_book/
 build/
+.npm/
 # Include the styleguide build directory, but not the StyleGuide component
 styleguide/
 !docs/components/overrides/StyleGuide

diff --git a/Dockerfile b/Dockerfile
@@ -23,9 +23,6 @@ RUN set -ex && \
 # Set the container's user to the newly created one.
 USER node
 
-# Prepare node-sass for the environment
-RUN npm rebuild node-sass
-
 # The entrypoint configures the container to be run as an executable.
 # Arguments supplied on the command line will be forwarded onto the entrypoint.
 ENTRYPOINT ["npm", "run"]

diff --git a/package.json b/package.json
@@ -27,7 +27,7 @@
     "contributors:update": "node scripts/update-contributors.js",
     "dev": "styleguidist server --config config/styleguide.config.js",
     "dev:e2e": "docker-compose up lib",
-    "dev:e2e-direct": "STYLEGUIDIST_ENV=e2e styleguidist server --config config/styleguide.config.js",
+    "dev:e2e-direct": "npm rebuild node-sass && STYLEGUIDIST_ENV=e2e styleguidist server --config config/styleguide.config.js",
     "gitbook": "gitbook serve guide",
     "gitbook:install": "gitbook install guide",
     "lerna:publish": "node scripts/publish.js",