Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/responsive image #1528

Merged
merged 11 commits into from
Mar 2, 2021
Merged

Feat/responsive image #1528

merged 11 commits into from
Mar 2, 2021

Conversation

kiesha-telus
Copy link
Contributor

@kiesha-telus kiesha-telus commented Feb 24, 2021

Related issues

See telus/tds-community#439

Embargo exception: https://tdrm-285714.ue.r.appspot.com/?id=408690152

Description

ResponsiveImage allows variation in image source based on screen size. This can be used for "art direction" and/or using compressed files and alternate formats based on different devices.

Checklist before submitting pull request

  • New code is unit tested
  • Commits follow our Developer Guide
  • For code changes, run npm run prepr locally
    • make sure visual and accessibility tests pass

@TDSBot
Copy link

TDSBot commented Feb 24, 2021

Links:

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@TDSBot
Copy link

TDSBot commented Feb 25, 2021

Links:

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

1 similar comment
@TDSBot
Copy link

TDSBot commented Feb 26, 2021

Links:

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

packages/ResponsiveImage/ResponsiveImage.jsx Outdated Show resolved Hide resolved
packages/ResponsiveImage/ResponsiveImage.md Outdated Show resolved Hide resolved
@TDSBot
Copy link

TDSBot commented Mar 1, 2021

Links:

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@jraff jraff force-pushed the feat/responsive-image branch from 84b0381 to a988123 Compare March 2, 2021 16:00
@TDSBot
Copy link

TDSBot commented Mar 2, 2021

Links:

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@TDSBot
Copy link

TDSBot commented Mar 2, 2021

Links:

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@jraff jraff merged commit 3ea8bf5 into master Mar 2, 2021
@jraff jraff deleted the feat/responsive-image branch March 2, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants