Upgrade PGML Python dependencies #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHend
reviewed
Dec 21, 2024
ChuckHend
requested changes
Dec 21, 2024
There was a problem hiding this comment.
The dockerfile will need to be updated to install pgml and its dependencies from source.
Then, test that the extension can not only be loaded but also that it functions properly. e.g. train a classification model, then load it and run some .predict through it. You could use the example in the ML Stack Docs as way to test it. If you can get through the guide, then its probably good enough.
|
New years goals. |
nhudson
approved these changes
Dec 21, 2024
|
For when we come back to this https://github.com/postgresml/postgresml/blob/master/docker/Dockerfile |
nhudson
approved these changes
Jan 3, 2025
theory
added a commit
that referenced
this pull request
Jan 17, 2025
And remove unused arguments from the `Dockerfile`.
ChuckHend
approved these changes
Jan 17, 2025
And remove unused arguments from the `Dockerfile`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove unused arguments from the
Dockerfile. Completes tem-2724.