Document failover version #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
document-failover-version
branch
from
8a8d41b to
88a476b
Compare
cretz
approved these changes
Mar 21, 2024
dandavison
force-pushed
the
document-failover-version
branch
from
88a476b to
2d226f1
Compare
bergundy
reviewed
Mar 21, 2024
bergundy
approved these changes
Mar 21, 2024
dandavison
force-pushed
the
document-failover-version
branch
from
22da891 to
fea76aa
Compare
Co-authored-by: Roey Berman <[email protected]>
bergundy
reviewed
Mar 21, 2024
Comment on lines
+770
to
+771
| // Namespace failover version. Defines alternate history branches that can arise in | ||
| // multi-cluster configurations (e.g. multi-region namespaces). |
There was a problem hiding this comment.
Sorry for not catching this earlier.
We refer to them global namespaces not multi-region so might want to adjust.
Suggested change
| // Namespace failover version. Defines alternate history branches that can arise in | |
| // multi-cluster configurations (e.g. multi-region namespaces). | |
| // Namespace failover version. Defines alternate history branches that can arise in | |
| // multi-cluster configurations (e.g. global namespaces). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.