GHA to create release #437
Conversation
|
Can you give some background on the savings here on starting a GH workflow vs publishing release in GH? |
rodrigozhou
force-pushed
the
rodrigozhou/gha-create-tag
branch
from
5d836bc to
bddfbea
Compare
There was a problem hiding this comment.
As mentioned at temporalio/api-go#170 (review), I am a bit concerned about the maintenance of these two workflows for such an incredibly simple thing, but if y'all are resolving to maintain them and are now in full control of the release process of this and the API repo, ok.
rodrigozhou
force-pushed
the
rodrigozhou/gha-create-tag
branch
from
bddfbea to
d0cd2bf
Compare
rodrigozhou
force-pushed
the
rodrigozhou/gha-create-tag
branch
from
d0cd2bf to
2cab9a7
Compare
.github/workflows/create-tag.yml
Outdated
| base_tag: | ||
| description: "Base tag to generate commit list for release notes" | ||
| required: false | ||
| skip_sdk_check: |
There was a problem hiding this comment.
@cretz mentioned a use case here: temporalio/sdk-go#1749 (review)
Thanks! Note, when making the api side, you may want the ability to bypass. The reason one might want to bypass is because we know the API is incompatible and we plan on tagging a new Go SDK release with the new API release immediately after API release is complete.
| if: | | ||
| !cancelled() && | ||
| needs.prepare-inputs.result == 'success' && | ||
| contains(fromJSON('["success", "skipped"]'), needs.check-compatibility-sdk-go.result) |
There was a problem hiding this comment.
I would have imagined this would be the default, is it not so?
There was a problem hiding this comment.
Github actions doesn't work well when the dependency has a condition for running.
In this case, the check-compatibility-sdk-go job runs only if the flag is set. So, even if I add it to needs, the create-release job never runs. So, I need to manually check the conditions.
rodrigozhou
force-pushed
the
rodrigozhou/gha-create-tag
branch
from
fa660a1 to
8a60658
Compare
What changed?
GHA to create, publish and delete releases.
create-release: manually triggered, it validates the input, checks compatibility with sdk-go, and creates draft releases inapiandapi-go.publish-release: triggered when a release is published, it publishes the correspondingapi-gorelease.delete-release: triggered when a release is deleted, it deletes the correspondingapi-gorelease (only works for deleting draft releases).Why?
Automation.
Breaking changes
Server PR