Add batch activity unpause operation #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jan 28, 2025
alexshtin
reviewed
Jan 29, 2025
alexshtin
approved these changes
Jan 29, 2025
cretz
reviewed
Jan 29, 2025
| @@ -117,3 +118,23 @@ message BatchOperationUpdateWorkflowExecutionOptions { | |||
| // To unset a field, set it to null and use the update mask to indicate that it should be mutated. | |||
| google.protobuf.FieldMask update_mask = 3; | |||
| } | |||
|
|
|||
| // BatchOperationPauseActivities sends unpause requests to batch workflows. | |||
| message BatchOperationUnpauseActivities { | |||
There was a problem hiding this comment.
Can we confirm implementation is mostly done before merge here?
There was a problem hiding this comment.
Yes. There is a link to Server PR in description. It will require some changes based on the feedback in this PRs, but all code is implemented
Sushisource
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add batch activity unpause operation.
Why?
Part of the activity API work.
Breaking changes
No
Server PR
Add batch activity unpause. Single activity commulative changes