Single-workflow Signal Command #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
commented
Jan 25, 2024
| if err != nil { | ||
| return fmt.Errorf("failed signalling workflow: %w", err) | ||
| } | ||
| cctx.Printer.Println("Signal workflow succeeded") |
There was a problem hiding this comment.
Up for discussion on whether this is a log statement or a normal line. If --output json is specified, there will be no output regardless.
There was a problem hiding this comment.
I'm not personally expecting a non-blocking request-response command such as signal to have a concept of "logging" -- I'm just expecting stdout and stderr.
There was a problem hiding this comment.
👍 This matches existing CLI where, in the absence of more detail, it just prints a line of success.
dandavison
approved these changes
Jan 25, 2024
…write-workflow-signal # Conflicts: # go.mod # go.sum # temporalcli/commands.gen.go # temporalcli/commands.workflow.go # temporalcli/commands.workflow_exec.go # temporalcli/commandsmd/commands.md
|
Closing this in favor of a new PR pointing to the cli-rewrite branch (coming soon) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This demonstrates how to write a simple command. Admittedly it didn't have to do much output or output testing and it could have more testing. Also, this does not include the "batch" capabilities of existing CLI.