Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose schedule memo and search attributes in list #434

Closed
wants to merge 1 commit into from

Conversation

dnr
Copy link
Member

@dnr dnr commented Jan 31, 2024

What was changed

Expose schedule's memo and search attributes in schedule list command.
Note these are not printed by default, you can use either -o json for a full dump or selectively enable them with --fields ScheduleId,SearchAttributes,Memo.
The values are always converted to strings for now. In the rewrite we can handle types better.

Why?

Fixes #433

Checklist

  1. How was this tested:
    manually

@cretz
Copy link
Member

cretz commented Jan 31, 2024

Hrmm, memo and search attributes aren't even shown when listing workflows. Should we do this there too?

(CLI refresh project has no concept of customizing list fields currently so we may have to add that concept)

@dnr
Copy link
Member Author

dnr commented Jan 31, 2024

I'm not sure customizing list fields is that useful. The key point to me is that the list view should be fairly readable, though it may omit some available information, and if you want all the information, you can use the json view and format manually.

@dnr
Copy link
Member Author

dnr commented Feb 28, 2024

Going to close this PR since we're rewriting things. This should be incorporated into #459.

@dnr dnr closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Schedule with memo option not updating memo
2 participants