EDU-709 - audit logging pages for GCP #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XaF
reviewed
Sep 11, 2024
There was a problem hiding this comment.
@MasonEgger could we keep that page (and the link to it) in a separate PR, and merge the rest ?
@alice-yin is going to double-check if we want the GCP PubSub details exposed yet; putting this as a separate PR will allow it to be ready to merge whenever, but to already have the reorg done.
Thoughts?
There was a problem hiding this comment.
Yes I will get a separate PR setup with the drafts. I may not update the other files until after the merge to avoid unnecessary merge conflicts and to make rebasing easier, but as soon as we do the GCP merge I'll rebase and get the links setup again.
Does this work for y'all?
There was a problem hiding this comment.
Here's the PR. #3080
Co-authored-by: Raphaël Beamonte <[email protected]>
Co-authored-by: Raphaël Beamonte <[email protected]>
Co-authored-by: Raphaël Beamonte <[email protected]>
Co-authored-by: Raphaël Beamonte <[email protected]>
XaF
reviewed
Sep 12, 2024
Co-authored-by: Raphaël Beamonte <[email protected]>
XaF
approved these changes
Sep 12, 2024
jsundai
reviewed
Sep 12, 2024
MasonEgger
commented
Sep 12, 2024
jsundai
reviewed
Sep 13, 2024
jsundai
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.